Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

flaky unit test: vttablet/tabletserver/vstreamer panic in goroutine after TestREKeyRange #5636

Closed
morgo opened this issue Dec 31, 2019 · 0 comments · Fixed by #5637
Closed

flaky unit test: vttablet/tabletserver/vstreamer panic in goroutine after TestREKeyRange #5636

morgo opened this issue Dec 31, 2019 · 0 comments · Fixed by #5637
Labels
Type: Bug

Comments

@morgo
Copy link
Contributor

morgo commented Dec 31, 2019

Still getting this occaisionally after recent stability fixes:

ok  	vitess.io/vitess/go/vt/vttablet/tabletserver/txthrottler	0.013s
E1231 21:31:42.484681   24840 vstreamer.go:669] stream error @ ee5765de-2c14-11ea-87a4-000d3a7c2040:1-60: table t1 not found
panic: Fail in goroutine after TestREKeyRange has completed

goroutine 294 [running]:
testing.(*common).Fail(0xc000110400)
	/opt/hostedtoolcache/go/1.12.14/x64/src/testing/testing.go:565 +0x11e
testing.(*common).Error(0xc000110400, 0xc0000c1f88, 0x1, 0x1)
	/opt/hostedtoolcache/go/1.12.14/x64/src/testing/testing.go:654 +0x79
vitess.io/vitess/go/vt/vttablet/tabletserver/vstreamer.startStream.func1(0xc000425c20, 0xed5cc0, 0xc00020d6c0, 0xc000110400, 0xc0004a63c0, 0x31, 0xc00020d700)
	/home/runner/work/vitess/vitess/go/vt/vttablet/tabletserver/vstreamer/vstreamer_test.go:1174 +0xf7
created by vitess.io/vitess/go/vt/vttablet/tabletserver/vstreamer.startStream
	/home/runner/work/vitess/vitess/go/vt/vttablet/tabletserver/vstreamer/vstreamer_test.go:1171 +0xc7
FAIL	vitess.io/vitess/go/vt/vttablet/tabletserver/vstreamer	8.474s
sougou added a commit to planetscale/vitess that referenced this issue Dec 31, 2019
@sougou
tests: fix panic in vstreamer_test
079ec56 
Fixes vitessio#5636

There was an unnecessary error check in a goroutine that could
terminate late. The check has been removed.

Signed-off-by: Sugu Sougoumarane <[email protected]>
@sougou sougou mentioned this issue Dec 31, 2019
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Type: Bug
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

tests: fix panic in vstreamer_test planetscale/vitess
1 participant
@morgo