Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add web_dir options back so as to not break existing binaries. Options are ignored #5747

Merged
merged 1 commit into from
Jan 22, 2020
Merged

Add web_dir options back so as to not break existing binaries. Options are ignored #5747

merged 1 commit into from
Jan 22, 2020

Conversation

rohit-nayak-ps
Copy link
Contributor

Signed-off-by: Rohit Nayak [email protected]

@deepthi deepthi requested a review from morgo January 21, 2020 23:49
morgo
morgo approved these changes Jan 21, 2020
View reviewed changes
Copy link
Contributor

@morgo morgo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, Thanks for fixing!

@morgo morgo merged commit 15472c1 into vitessio:master Jan 22, 2020
@morgo morgo mentioned this pull request Jan 22, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@morgo morgo morgo approved these changes

@sougou sougou Awaiting requested review from sougou

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@rohit-nayak-ps @morgo