Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Default testsuite to RBR #5588

Merged
merged 5 commits into from
Jan 3, 2020
Merged

Conversation

ajeetj
Copy link
Contributor

@ajeetj ajeetj commented Dec 18, 2019

Fixes #5395

Default RBR for python tests
Reset to SBR wherever required for special testcases.
Removed TestStatementReplicationWithRealDatabase as it was failing to test statement based replication which is deprecated.

Signed-off-by: Ajeet jain [email protected]

Copy link
Contributor

@dkhenry dkhenry left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ajeetj ajeetj force-pushed the tal_test_rbr_default branch from c04ac16 to d9d6cb3 Compare December 31, 2019 10:09
Signed-off-by: Ajeet jain <[email protected]>
@ajeetj ajeetj force-pushed the tal_test_rbr_default branch from d9d6cb3 to d5eab08 Compare December 31, 2019 10:43
@ajeetj
Copy link
Contributor Author

ajeetj commented Jan 2, 2020

@morgo Can you take a look at this when you get a chance?

  1. I had to remove a bunch of /* _stream vitess ..../* comments to fix mysql and vttablet endtoend test cases. I am not yet sure why we needed to remove in this PR.
  2. go/vt/vttablet/endtoend/misc_test.go TestUpsertNonPKHit was failing which I have excluded for now. I was not sure if we support that case. But we need to fix that test before merging.

@morgo
Copy link
Contributor

morgo commented Jan 2, 2020

@morgo Can you take a look at this when you get a chance?

  1. I had to remove a bunch of /* _stream vitess ..../* comments to fix mysql and vttablet endtoend test cases. I am not yet sure why we needed to remove in this PR.
  2. go/vt/vttablet/endtoend/misc_test.go TestUpsertNonPKHit was failing which I have excluded for now. I was not sure if we support that case. But we need to fix that test before merging.

I'm not sure on these two. Perhaps @sougou will understand context.

@morgo morgo merged commit 14d4739 into vitessio:master Jan 3, 2020
@ajeetj ajeetj deleted the tal_test_rbr_default branch January 3, 2020 03:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Testsuite requires SBR enabled to pass
3 participants