Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Deprecated warning with new hashicorp/aws v5.0.1 provider #2635

Closed
khosro-copper opened this issue May 30, 2023 · 13 comments · Fixed by #2858
Closed

Deprecated warning with new hashicorp/aws v5.0.1 provider #2635

khosro-copper opened this issue May 30, 2023 · 13 comments · Fixed by #2858
Milestone

Comments

@khosro-copper
Copy link

With latest hashicorp/aws v5.0.1 provider as well as latest terraform-aws-eks module, when I run terraform plan, I see this deprecated warning for aws addons:

Warning: Argument is deprecated

with aws_eks_addon.this["coredns"],
on main.tf line 388, in resource "aws_eks_addon" "this":
388:   resolve_conflicts        = try(each.value.resolve_conflicts, "OVERWRITE")

The "resolve_conflicts" attribute can't be set to "PRESERVE" on initial
resource creation. Use "resolve_conflicts_on_create" and/or
"resolve_conflicts_on_update" instead

(and one more similar warning elsewhere)

If update main.tf with recommended suggestion, it should work as I test it locally.
Thanks!

@khosro-copper
Copy link
Author

Just checking if there is any update for this issue? :)

@bryantbiggs
Copy link
Member

not at this time - to resolve requires a breaking change and its simply a warning. I would suggest raising this with the Terraform core product to provide user the ability to show/silence warnings in output - as it stands today, this value is still perfectly valid and continues to operate until the next v6.0 release of the AWS provider (at least a year from now)

@github-actions
Copy link

github-actions bot commented Jul 2, 2023

This issue has been automatically marked as stale because it has been open 30 days
with no activity. Remove stale label or comment or this issue will be closed in 10 days

@github-actions github-actions bot added the stale label Jul 2, 2023
@bryantbiggs bryantbiggs added wip and removed stale labels Jul 2, 2023
bryfox pushed a commit to foxglove/terraform-examples that referenced this issue Jul 10, 2023
### Public-Facing Changes

Updated the Terraform modules used in the AWS and GCP examples to their
latest versions.

This PR also includes the Terraform lockfile as per [their
recommendation](https://developer.hashicorp.com/terraform/language/files/dependency-lock)
— not sure why we put them in Gitignore in the first place but hey ho.

Note that there's a deprecation warning in the Terraform AWS EKS module.
Nothing for us to do right now, people of the module are aware:
terraform-aws-modules/terraform-aws-eks#2635

### Testing

Tested with an end-to-end `terraform apply` & `terraform destroy` for
both aws & gcp.
@bryantbiggs bryantbiggs added this to the v20.0.0 milestone Oct 9, 2023
@vstthomas
Copy link

Sorry, I'm still seeing this post-v5+.

Warning: Argument is deprecated

  with module.eks.aws_eks_addon.this["kube-proxy"],
  on .terraform/modules/eks/main.tf line 399, in resource "aws_eks_addon" "this":
 399:   resolve_conflicts        = try(each.value.resolve_conflicts, "OVERWRITE")

The "resolve_conflicts" attribute can't be set to "PRESERVE" on initial resource creation. Use "resolve_conflicts_on_create" and/or "resolve_conflicts_on_update" instead

(and 2 more similar warnings elsewhere)

Applies to L399 and L427.

% tf version
Terraform v1.6.3
on darwin_arm64
+ provider registry.terraform.io/hashicorp/aws v5.26.0
+ provider registry.terraform.io/hashicorp/cloudinit v2.3.2
+ provider registry.terraform.io/hashicorp/kubernetes v2.23.0
+ provider registry.terraform.io/hashicorp/time v0.9.1
+ provider registry.terraform.io/hashicorp/tls v4.0.4

@bryantbiggs
Copy link
Member

thats because it hasn't been resolved in this module yet - it will be resolved once v20.x is released

@vstthomas
Copy link

sorry, paying too much attention to the version in the subject "hashicorp/aws v5.0.1 provider" 😬

do we have a rough ETA on v20.x?

@bryantbiggs
Copy link
Member

It will be this year (2023)

@sasha2002
Copy link

It's 2024 and no version 20 :(

@bryantbiggs
Copy link
Member

unfortunately v20 is blocked until hashicorp/terraform-provider-aws#35037 is added since thats the main component of v20

@MoustafaAMahmoud
Copy link

It seems EKS access entry and policy association changes #35037 has been merged. Do we have any updates about the release date?

@bryantbiggs
Copy link
Member

It did, and I started adding it but there were some issues that have been patched and will go out on 5.34.0

@antonbabenko
Copy link
Member

This issue has been resolved in version 20.0.0 🎉

Copy link

github-actions bot commented Mar 4, 2024

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. If you have found a problem that seems similar to this, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Mar 4, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
6 participants