Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore(eks-public) update deprecated EIP terraform configuration #458

Merged
merged 1 commit into from
Sep 20, 2023
Merged

chore(eks-public) update deprecated EIP terraform configuration #458

merged 1 commit into from
Sep 20, 2023

Conversation

dduportal
Copy link
Contributor

@dduportal dduportal commented Sep 19, 2023 •
edited
Loading

As per https://registry.terraform.io/providers/hashicorp/aws/latest/docs/resources/eip#vpc, the attribute vpc is deprecated for resources of type aws_eip.

This PR fixes the warning message: no change expected.

@dduportal
Copy link
Contributor Author

Please note that we still have another warning in the terraform plan output which cannot be resolved at the time being:

Warnings:

- Argument is deprecated
  on .terraform/modules/cik8s/main.tf line 392 (and 7 more)

Ref. terraform-aws-modules/terraform-aws-eks#2635

@dduportal dduportal marked this pull request as ready for review September 19, 2023 17:27
@dduportal dduportal requested review from a team, timja, lemeurherve and smerle33 September 19, 2023 17:27
@dduportal dduportal merged commit 7abb914 into jenkins-infra:main Sep 20, 2023
@dduportal dduportal deleted the chore/remove-vpc-warning branch September 20, 2023 08:07
@dduportal dduportal mentioned this pull request Oct 19, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@timja timja timja approved these changes

@lemeurherve lemeurherve Awaiting requested review from lemeurherve

@smerle33 smerle33 Awaiting requested review from smerle33

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@dduportal @timja