Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

resolve_conflicts is deprecated in v5+ of the aws provider; usage in eks module leads to error when adding addons #2825

Closed
life5ign opened this issue Nov 21, 2023 · 3 comments

Comments

@life5ign
Copy link

This line:
https://github.com/terraform-aws-modules/terraform-aws-eks/blob/ec454c51cb0026254b68cafe7aa9d05f873af990/main.tf#L399C1-L400C1

Leads to the error

│ Warning: Argument is deprecated
│ 
│   with module.eks.aws_eks_addon.this["kube-proxy"],
│   on .terraform/modules/eks/main.tf line 399, in resource "aws_eks_addon" "this":
│  399:   resolve_conflicts        = try(each.value.resolve_conflicts, "OVERWRITE")
│ 
│ The "resolve_conflicts" attribute can't be set to "PRESERVE" on initial resource creation. Use "resolve_conflicts_on_create" and/or
│ "resolve_conflicts_on_update" instead
│ 
│ (and one more similar warning elsewhere)

When creating or adding these addons to a cluster that doesn't have them (it only has the self managed, K8s versions of them)

module "eks" {
  # .......

  cluster_addons = {
      coredns = {
        most_recent = true
        resolve_conflicts = 
      }
      kube-proxy = {
        most_recent = true
      }
  }
}
@bryantbiggs
Copy link
Member

its a warning, not an error - closing as a duplicate of #2635

@life5ign
Copy link
Author

just saw that, thanks for looking into it

Copy link

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. If you have found a problem that seems similar to this, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Dec 22, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants