EKS access entry and policy association changes

[sasidhar-aws]

Description

Work in progress to implement access_entry and access_policy_association resources

Relations

Closes #34982

References

Output from Acceptance Testing

% make testacc TESTS=TestAccXXX PKG=ec2

...

[github-actions]

Community Note

Voting for Prioritization

• Please vote on this pull request by adding a 👍 reaction to the original post to help the community and maintainers prioritize this pull request.
• Please see our prioritization guide for information on how we prioritize.
• Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for issue followers and do not help prioritize the request.

For Submitters

• Review the contribution guide relating to the type of change you are making to ensure all of the necessary steps have been taken.
• For new resources and data sources, use skaff to generate scaffolding with comments detailing common expectations.
• Whether or not the branch has been rebased will not impact prioritization, but doing so is always a welcome surprise.

[andyspiers]

Some minor grammatical suggestions for the docs

[ewbankkit]

LGTM 🚀.

% make testacc TESTARGS='-run=TestAccEKSCluster_AccessConfig\|TestAccEKSCluster_basic\|TestAccEKSClusterDataSource_basic' PKG=eks ACCTEST_PARALLELISM=2
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./internal/service/eks/... -v -count 1 -parallel 2  -run=TestAccEKSCluster_AccessConfig\|TestAccEKSCluster_basic\|TestAccEKSClusterDataSource_basic -timeout 360m
=== RUN   TestAccEKSClusterDataSource_basic
=== PAUSE TestAccEKSClusterDataSource_basic
=== RUN   TestAccEKSCluster_basic
=== PAUSE TestAccEKSCluster_basic
=== RUN   TestAccEKSCluster_AccessConfig_create
=== PAUSE TestAccEKSCluster_AccessConfig_create
=== RUN   TestAccEKSCluster_AccessConfig_update
=== PAUSE TestAccEKSCluster_AccessConfig_update
=== CONT  TestAccEKSClusterDataSource_basic
=== CONT  TestAccEKSCluster_AccessConfig_create
--- PASS: TestAccEKSClusterDataSource_basic (647.09s)
=== CONT  TestAccEKSCluster_AccessConfig_update
--- PASS: TestAccEKSCluster_AccessConfig_create (670.26s)
=== CONT  TestAccEKSCluster_basic
--- PASS: TestAccEKSCluster_basic (619.94s)
--- PASS: TestAccEKSCluster_AccessConfig_update (1495.46s)
PASS
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/eks	1916.223s

% make testacc TESTARGS='-run=TestAccEKSAccessEntryDataSource_\|TestAccEKSAccessEntry_' PKG=eks ACCTEST_PARALLELISM=2
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./internal/service/eks/... -v -count 1 -parallel 2  -run=TestAccEKSAccessEntryDataSource_\|TestAccEKSAccessEntry_ -timeout 360m
=== RUN   TestAccEKSAccessEntryDataSource_basic
=== PAUSE TestAccEKSAccessEntryDataSource_basic
=== RUN   TestAccEKSAccessEntry_basic
=== PAUSE TestAccEKSAccessEntry_basic
=== RUN   TestAccEKSAccessEntry_disappears
=== PAUSE TestAccEKSAccessEntry_disappears
=== RUN   TestAccEKSAccessEntry_tags
=== PAUSE TestAccEKSAccessEntry_tags
=== CONT  TestAccEKSAccessEntryDataSource_basic
=== CONT  TestAccEKSAccessEntry_disappears
--- PASS: TestAccEKSAccessEntry_disappears (550.28s)
=== CONT  TestAccEKSAccessEntry_tags
--- PASS: TestAccEKSAccessEntryDataSource_basic (578.12s)
=== CONT  TestAccEKSAccessEntry_basic
--- PASS: TestAccEKSAccessEntry_basic (615.79s)
--- PASS: TestAccEKSAccessEntry_tags (618.88s)
PASS
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/eks	1221.682s

% make testacc TESTARGS='-run=TestAccEKSAccessEntry_Disappears_cluster\|TestAccEKSAccessPolicyAssociation_' PKG=eks ACCTEST_PARALLELISM=2
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./internal/service/eks/... -v -count 1 -parallel 2  -run=TestAccEKSAccessEntry_Disappears_cluster\|TestAccEKSAccessPolicyAssociation_ -timeout 360m
=== RUN   TestAccEKSAccessEntry_Disappears_cluster
=== PAUSE TestAccEKSAccessEntry_Disappears_cluster
=== RUN   TestAccEKSAccessPolicyAssociation_basic
=== PAUSE TestAccEKSAccessPolicyAssociation_basic
=== RUN   TestAccEKSAccessPolicyAssociation_disappears
=== PAUSE TestAccEKSAccessPolicyAssociation_disappears
=== RUN   TestAccEKSAccessPolicyAssociation_Disappears_cluster
=== PAUSE TestAccEKSAccessPolicyAssociation_Disappears_cluster
=== CONT  TestAccEKSAccessEntry_Disappears_cluster
=== CONT  TestAccEKSAccessPolicyAssociation_disappears
--- PASS: TestAccEKSAccessPolicyAssociation_disappears (614.63s)
=== CONT  TestAccEKSAccessPolicyAssociation_Disappears_cluster
--- PASS: TestAccEKSAccessEntry_Disappears_cluster (649.69s)
=== CONT  TestAccEKSAccessPolicyAssociation_basic
--- PASS: TestAccEKSAccessPolicyAssociation_Disappears_cluster (560.58s)
--- PASS: TestAccEKSAccessPolicyAssociation_basic (571.48s)
PASS
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/eks	1230.880s

[ewbankkit]

@sasidhar-aws Thanks for the contribution 🎉 👏.

[github-actions]

This functionality has been released in v5.33.0 of the Terraform AWS Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you!

[AndrewChubatiuk]

@ewbankkit why type in aws_eks_access_entry is Computed? It should be configurable

[iandrewt]

Agreed - I'd like to use this to configure access entries for Karpenter nodes, which aren't covered by the autoconfiguration for managed node groups.

[AndrewChubatiuk]

@iandrewt added PR #35391

[panekj]

it's missing user_name field as well

[AndrewChubatiuk]

@panekj added user_name as well

[sidewinder12s]

Typo

Suggested change

	page_title: "AWS: aws_eks_access_policy_associattion"
	page_title: "AWS: aws_eks_access_policy_association"

[dominik-ba]

May I ask why access_scope is a block and namespaces & type not a top level argument?

[panekj]

May I ask why access_scope is a block and namespaces & type not a top level argument?

because that's how AWS API defines it: https://docs.aws.amazon.com/eks/latest/APIReference/API_AccessScope.html

[github-actions]

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.