feat(nsis): implement passive mode, closes #6955

[amrbashir]

What kind of change does this PR introduce?

• Bugfix
• Feature
• Docs
• New Binding issue #___
• Code style update
• Refactor
• Build-related changes
• Other, please describe:

Does this PR introduce a breaking change?

• Yes, and the changes were approved in issue #___
• No

Checklist

• When resolving issues, they are referenced in the PR's title (e.g fix: remove a typo, closes #___, #___)
• A change file is added if any packages will require a version bump due to this PR per the instructions in the readme.
• I have added a convincing reason for adding this feature, if necessary

Other information

[FabianLars]

It doesn't seem to work when used in the updater, it will still show the default dialog. Using the flags in the console the passive mode (which looks nice btw) does work.

I didn't triage it yet, just wanted to give a headsup so we don't merge it too eagerly :)

[amrbashir]

thanks Fabian, I will test again tomorrow.

[FabianLars]

Found it:

tauri/core/tauri/src/updater/core.rs

Lines 739 to 743 in abdd256

	if crate::utils::config::WindowsUpdateInstallMode::Quiet
	== config.tauri.updater.windows.install_mode
	{
	installer.args(config.tauri.updater.windows.install_mode.nsis_args());
	}

[amrbashir]

Nice catch 💯 , I checked that code twice to make sure the args are passed in, but didn't pay attention to the if check.

[FabianLars]

Sorry for the delay, i really thought i approved already...

On a side node i just noticed, when the update is installed, the nsis dialog doesn't get focus and will be stuck behind other windows. -> This is the same for passive and basicUi modes. It's alright-ish for the passive mode but more problematic when user action is required (basicUi). Anyway, that's prob something for a different PR just wanted to raise awareness.

[lucasfernog]

@FabianLars can you open an issue so we don't foget about this issue?

[lucasfernog]

Works well. I know sometimes it's complicated to do it, but ideally each feature would have its own PR. I promise I'll try to be faster reviewing it 😂

[amrbashir]

It is my bad, I just kept finding bugs as I was implementing the passive mode and was fixing them along the way.