feat(core): Ability to disable minimize/maximize/close native window's buttons, closes #2353 #6665

TDiblik · 2023-04-08T19:37:43Z

What kind of change does this PR introduce?

Does this PR introduce a breaking change?

Yes, and the changes were approved in issue #___
No

Checklist

When resolving issues, they are referenced in the PR's title (e.g fix: remove a typo, closes #___, #___)
A change file is added if any packages will require a version bump due to this PR per the instructions in the readme.
I have added a convincing reason for adding this feature, if necessary ---- This PR resolves issue/feature request Ability to disable minimize/maximize/close #2353

Other information

This PR intentionally exposes functionality only to rust api (from tao). I believe that since this functionality manipulates native window's titlebar buttons state, it should not be accessible from TypeScript (although I'll be more than happy to implement it if necessary/you wish)

…w builder and attributes

amrbashir

Nice work, thank you for the contribution.

A couple of things to note:

It is fine to expose these methods in typescript as well as the window config options.
You seem to have left the platform-specific documentation from tao, We need to document them in tauri as well.

core/tauri/src/window.rs

Co-authored-by: Amr Bashir <[email protected]>

TDiblik · 2023-04-11T16:37:57Z

Nice work, thank you for the contribution.

A couple of things to note:

It is fine to expose these methods in typescript as well as the window config options.

You seem to have left the platform-specific documentation from tao, We need to document them in tauri as well.

Hi, thanks for the feedback!

Will do! --- UPDATE: (Done, requesting re-review, since I'm unsure about the second point)
Could you please expand on this point? I made the docs by "copying/replicating" the style of resizable methods

This commit was made from my notebook, instead of my pc, because windows was generating these files weirdly

amrbashir · 2023-04-12T11:51:44Z

The tao functions you're trying to expose contain platform-specific information in its documentation like this one https://docs.rs/tao/latest/tao/window/struct.Window.html#method.set_closable and we need to document the same here as well.

…ction This commit is outside of the PR focus, however I saw some docs that did not match the function, so I fixed it

TDiblik · 2023-04-14T19:07:21Z

Hi, thanks for more info!

I've updated docs based on your previous comment (added platform specific information). Docs inside tauri and tao should now match.

core/tauri-runtime/src/webview.rs

core/tauri-utils/src/config.rs

core/tauri/src/window.rs

tooling/api/src/window.ts

Co-authored-by: Amr Bashir <[email protected]>

amrbashir

Thank you very much

TDiblik · 2023-04-17T00:38:22Z

NP! Thank you for reviewing, referencing materials and overall smooth PR flow!

…bar-buttons-state

Co-authored-by: wusyong <[email protected]> Co-authored-by: Fabian-Lars <[email protected]> Co-authored-by: Lucas Nogueira <[email protected]> Co-authored-by: Simon Hyll <[email protected]> Co-authored-by: Lucas Fernandes Nogueira <[email protected]> Co-authored-by: Lucas Nogueira <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com> Co-authored-by: Lucas Fernandes Nogueira <[email protected]> Co-authored-by: Amr Bashir <[email protected]> Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com> Co-authored-by: chip <[email protected]> Co-authored-by: Raphii <[email protected]> Co-authored-by: Ronie Martinez <[email protected]> Co-authored-by: hanaTsuk1 <[email protected]> Co-authored-by: nathan-fall <[email protected]> Co-authored-by: Akshay <[email protected]> Co-authored-by: KurikoMoe <[email protected]> Co-authored-by: Guilherme Oenning <[email protected]> Co-authored-by: Pierre Cashon <[email protected]> Co-authored-by: Jack Wills <[email protected]> Co-authored-by: Amirhossein Akhlaghpour <[email protected]> Co-authored-by: Risto Stevcev <[email protected]> Co-authored-by: Soumt <[email protected]> Co-authored-by: yutotnh <[email protected]> Co-authored-by: Gökçe Merdun <[email protected]> Co-authored-by: Nathanael Rea <[email protected]> Co-authored-by: Usman Rajab <[email protected]> Co-authored-by: Francis The Basilisk <[email protected]> Co-authored-by: Lej77 <[email protected]> Co-authored-by: Tomáš Diblík <[email protected]> Co-authored-by: Jonas Kruckenberg <[email protected]> Co-authored-by: Pascal Sommer <[email protected]> Co-authored-by: Bo <[email protected]> Co-authored-by: Kevin Yue <[email protected]> fixed grammar and typos (#6937) Fix api.js docs pipeline with updated typedoc dependencies (#6945) closes #6887 (#6922) fix(core): Fix `WindowBuilder::on_navigation` handler never registerd, closes #6865 (#6921) fix(core): Fix `WindowBuilder::on_navigation` handler never registerd, closes #6865 fix broken symlinks in license files (#6336) fix(cli): fix cli connection timeout to dev server (fix #6045) (#6046) fix(bundler): ensure that there are no duplicate extension arguments when bundling on Windows, fixes #6103 (#6917) fix(bundler): ensure that there are no duplicate extension arguments during bundling on Windows (fix #6103) closes #5491 (#6408) fix(nsis): prefill $INSTDIR with previous install path and respect `/D` flag, closes #6928 (#6935) fix(nsis): prefill $INSTDIR with previous install path and respect `/D` flag, closes #6928 fix(updater): emit `UPTODATE` when server responds with 204, closes #6934 (#6970) fix(core): unpin all dependencies, closes #6944 (#6966) fix(bundler): Add new lang_file option in persian variant. (#6972) fix(core/ipc): access url through webview native object, closes #6889 (#6976) fix(core): remove trailing slash in http scope url, closes #5208 (#6974) fix(core): remove trailing slash in http scope url, closes #5208 fix(cli): find correct binary when `--profile` is used, closes #6954 (#6979) fix(cli): find correct binary when `--profile` is used, closes #6954 closes #6955 (#6987) closes #6955 closes #6158 (#6969) closes #6158 fix(cli): improve vs build tools detection (#6982) fix: updated appimage script to follow symlinks for /usr/lib* (fix: #6992) (#6996) fix(cli): correctly remove Cargo features (#7013) Fix typo (#7012) fix(cli): revert metadata.json field rename from #6795 (#7029) closes #6732 (#6736) fix: add missing file properties on Windows, closes #6676 (#6693) fix(cli.js): detect node-20 binary (#6667) fix version-or-publish workflow (#7031) fix(cli/devserver): inject autoreload into HTML only, closes #6997 (#7032) fix(bundler/nsis): write installer templates UTF16LE encoded, closes #7036 (#7040) fix(bundler/nsis): write installer templates UTF16LE encoded, closes #7036 fix(core): rewrite `asset` protocol streaming, closes #6375 (#6390) closes #5939 (#5960) fix(core): use `safe_block_on` (#7047) closes #6859 (#6933) closes #6955 (#6998) fix(core): populate webview_attrs from config, closes #6794 (#6797) closes #5176 (#5180) fix: sound for notifications on windows (fix #6652) (#6680) close native window's buttons, closes #2353 (#6665) fix(bundler/nsis): calculate accurate app size, closes #7056 (#7057) fix(tests): only download update when it is available (#7061) closes #6706 (#6712) fix(doc): correct the doc of `content_protected()` (#7065) closes #6472 (#6530) fix(macros): use full path to Result to avoid issues with type aliases (#7071)

TDiblik added 6 commits April 8, 2023 15:52

feat(core): expose maximizability/minimizability/closability to windo…

963bae8

…w builder and attributes

feat(utils): ability to set button states from tauri.conf.json

6c43a48

chore: summarize changes

58f60d6

chore: docs

07491f8

chore: add generated schemas

3028b5e

chore: docs

b1371bc

TDiblik requested a review from a team as a code owner April 8, 2023 19:37

TDiblik changed the title ~~Feature request - Ability to disable minimize/maximize/close native window's buttons, closes #2353~~ feat(core, utils): Ability to disable minimize/maximize/close native window's buttons, closes #2353 Apr 8, 2023

TDiblik changed the title ~~feat(core, utils): Ability to disable minimize/maximize/close native window's buttons, closes #2353~~ feat(core/utils): Ability to disable minimize/maximize/close native window's buttons, closes #2353 Apr 8, 2023

amrbashir requested changes Apr 10, 2023

View reviewed changes

core/tauri/src/window.rs Outdated Show resolved Hide resolved

chore(core): make comments consistent

58d0394

Co-authored-by: Amr Bashir <[email protected]>

TDiblik added 5 commits April 11, 2023 21:16

feat(core/api): Expose new api for typescript and config features

45820bc

chore: docs

1d72277

chore(core/api): add generated schemas

3ef3365

chore(meta): update changes to reflect current state

79e2d56

chore(core/api): add generated files

dcc5aa1

This commit was made from my notebook, instead of my pc, because windows was generating these files weirdly

TDiblik requested a review from amrbashir April 11, 2023 20:36

TDiblik added 4 commits April 14, 2023 19:16

fix(ci)

46f0f56

chore(docs): Add platform specific documentation

1916c96

chore(tooling): Rename/Remove params inside docs that don't match fun…

e7e9da2

…ction This commit is outside of the PR focus, however I saw some docs that did not match the function, so I fixed it

chore(core/api) add generated files

22a2726

amrbashir requested changes Apr 14, 2023

View reviewed changes

TDiblik and others added 5 commits April 14, 2023 22:38

chore(api): formatting

e02e195

Co-authored-by: Amr Bashir <[email protected]>

chore(api): formatting

a3efd51

Co-authored-by: Amr Bashir <[email protected]>

chore(api): formatting

5cf766d

Co-authored-by: Amr Bashir <[email protected]>

chore(api): formatting

8c45842

Co-authored-by: Amr Bashir <[email protected]>

chore(api): formatting

fe8f77f

Co-authored-by: Amr Bashir <[email protected]>

TDiblik and others added 4 commits April 14, 2023 22:39

chore(api): formatting

2f72907

Co-authored-by: Amr Bashir <[email protected]>

docs(core): Insert platform specific comments instead of linking

51697f0

docs(core): Insert platform specific comments instead of linking

4801768

chore(tooling): Add more info to configuration docs

e4e6bda

TDiblik requested a review from amrbashir April 16, 2023 22:03

amrbashir previously approved these changes Apr 16, 2023

View reviewed changes

lucasfernog requested a review from a team May 22, 2023 14:42

lucasfernog added 2 commits May 24, 2023 15:43

Merge remote-tracking branch 'origin/dev' into feature/2353-set-title…

1ffdf28

…bar-buttons-state

split change files

0bab7b6

lucasfernog dismissed amrbashir’s stale review via 0bab7b6 May 24, 2023 18:52

lucasfernog changed the title ~~feat(core/utils): Ability to disable minimize/maximize/close native window's buttons, closes #2353~~ feat(core): Ability to disable minimize/maximize/close native window's buttons, closes #2353 May 24, 2023

lucasfernog and others added 3 commits May 24, 2023 15:54

update docs

4e0acca

fix covector

ff48bbb

update api example

9e8386b

lucasfernog approved these changes May 24, 2023

View reviewed changes

lucasfernog merged commit c4d6fb4 into tauri-apps:dev May 24, 2023

wusyong added the security: needs audit This issue/PR needs a security audit label May 25, 2023

lucasfernog added a commit that referenced this pull request May 26, 2023

chore(api): document new options from #6665

6d08c66

lucasfernog added a commit that referenced this pull request May 27, 2023

chore(api): document new options from #6665 (#7072)

3303041

lucasfernog mentioned this pull request May 27, 2023

feat(window): add option to disable controls tauri-apps/plugins-workspace#406

Merged

chippers added security: reviewed This issue/PR has been review by wg-security and removed security: needs audit This issue/PR needs a security audit labels Jun 15, 2023

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

feat(core): Ability to disable minimize/maximize/close native window's buttons, closes #2353 #6665

feat(core): Ability to disable minimize/maximize/close native window's buttons, closes #2353 #6665

TDiblik commented Apr 8, 2023

amrbashir left a comment

TDiblik commented Apr 11, 2023 •

edited

Loading

amrbashir commented Apr 12, 2023

TDiblik commented Apr 14, 2023

amrbashir left a comment

TDiblik commented Apr 17, 2023

feat(core): Ability to disable minimize/maximize/close native window's buttons, closes #2353 #6665

feat(core): Ability to disable minimize/maximize/close native window's buttons, closes #2353 #6665

Conversation

TDiblik commented Apr 8, 2023

What kind of change does this PR introduce?

Does this PR introduce a breaking change?

Checklist

Other information

amrbashir left a comment

Choose a reason for hiding this comment

TDiblik commented Apr 11, 2023 • edited Loading

amrbashir commented Apr 12, 2023

TDiblik commented Apr 14, 2023

amrbashir left a comment

Choose a reason for hiding this comment

TDiblik commented Apr 17, 2023

TDiblik commented Apr 11, 2023 •

edited

Loading