-
-
Notifications
You must be signed in to change notification settings - Fork 2.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[bug] WixUtilExtension in custom fragments make light.exe invocation fail when bundling Windows app #6103
Labels
Comments
agersant
added
status: needs triage
This issue needs to triage, applied to new issues
type: bug
labels
Jan 19, 2023
agersant
changed the title
[bug] WixUIExtension in custom fragments make light.exe invocation fail when bundling Windows app
[bug] WixUtilExtension in custom fragments make light.exe invocation fail when bundling Windows app
Jan 19, 2023
Closely related to this issue, it's currently not possible to use |
biaocy
added a commit
to biaocy/tauri
that referenced
this issue
May 9, 2023
…during bundling on Windows (fix tauri-apps#6103)
13 tasks
biaocy
added a commit
to biaocy/tauri
that referenced
this issue
May 12, 2023
…during bundling on Windows (fix tauri-apps#6103)
biaocy
added a commit
to biaocy/tauri
that referenced
this issue
May 12, 2023
…during bundling on Windows (fix tauri-apps#6103)
lucasfernog
added a commit
that referenced
this issue
May 30, 2023
Co-authored-by: wusyong <[email protected]> Co-authored-by: Fabian-Lars <[email protected]> Co-authored-by: Lucas Nogueira <[email protected]> Co-authored-by: Simon Hyll <[email protected]> Co-authored-by: Lucas Fernandes Nogueira <[email protected]> Co-authored-by: Lucas Nogueira <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com> Co-authored-by: Lucas Fernandes Nogueira <[email protected]> Co-authored-by: Amr Bashir <[email protected]> Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com> Co-authored-by: chip <[email protected]> Co-authored-by: Raphii <[email protected]> Co-authored-by: Ronie Martinez <[email protected]> Co-authored-by: hanaTsuk1 <[email protected]> Co-authored-by: nathan-fall <[email protected]> Co-authored-by: Akshay <[email protected]> Co-authored-by: KurikoMoe <[email protected]> Co-authored-by: Guilherme Oenning <[email protected]> Co-authored-by: Pierre Cashon <[email protected]> Co-authored-by: Jack Wills <[email protected]> Co-authored-by: Amirhossein Akhlaghpour <[email protected]> Co-authored-by: Risto Stevcev <[email protected]> Co-authored-by: Soumt <[email protected]> Co-authored-by: yutotnh <[email protected]> Co-authored-by: Gökçe Merdun <[email protected]> Co-authored-by: Nathanael Rea <[email protected]> Co-authored-by: Usman Rajab <[email protected]> Co-authored-by: Francis The Basilisk <[email protected]> Co-authored-by: Lej77 <[email protected]> Co-authored-by: Tomáš Diblík <[email protected]> Co-authored-by: Jonas Kruckenberg <[email protected]> Co-authored-by: Pascal Sommer <[email protected]> Co-authored-by: Bo <[email protected]> Co-authored-by: Kevin Yue <[email protected]> fixed grammar and typos (#6937) Fix api.js docs pipeline with updated typedoc dependencies (#6945) closes #6887 (#6922) fix(core): Fix `WindowBuilder::on_navigation` handler never registerd, closes #6865 (#6921) fix(core): Fix `WindowBuilder::on_navigation` handler never registerd, closes #6865 fix broken symlinks in license files (#6336) fix(cli): fix cli connection timeout to dev server (fix #6045) (#6046) fix(bundler): ensure that there are no duplicate extension arguments when bundling on Windows, fixes #6103 (#6917) fix(bundler): ensure that there are no duplicate extension arguments during bundling on Windows (fix #6103) closes #5491 (#6408) fix(nsis): prefill $INSTDIR with previous install path and respect `/D` flag, closes #6928 (#6935) fix(nsis): prefill $INSTDIR with previous install path and respect `/D` flag, closes #6928 fix(updater): emit `UPTODATE` when server responds with 204, closes #6934 (#6970) fix(core): unpin all dependencies, closes #6944 (#6966) fix(bundler): Add new lang_file option in persian variant. (#6972) fix(core/ipc): access url through webview native object, closes #6889 (#6976) fix(core): remove trailing slash in http scope url, closes #5208 (#6974) fix(core): remove trailing slash in http scope url, closes #5208 fix(cli): find correct binary when `--profile` is used, closes #6954 (#6979) fix(cli): find correct binary when `--profile` is used, closes #6954 closes #6955 (#6987) closes #6955 closes #6158 (#6969) closes #6158 fix(cli): improve vs build tools detection (#6982) fix: updated appimage script to follow symlinks for /usr/lib* (fix: #6992) (#6996) fix(cli): correctly remove Cargo features (#7013) Fix typo (#7012) fix(cli): revert metadata.json field rename from #6795 (#7029) closes #6732 (#6736) fix: add missing file properties on Windows, closes #6676 (#6693) fix(cli.js): detect node-20 binary (#6667) fix version-or-publish workflow (#7031) fix(cli/devserver): inject autoreload into HTML only, closes #6997 (#7032) fix(bundler/nsis): write installer templates UTF16LE encoded, closes #7036 (#7040) fix(bundler/nsis): write installer templates UTF16LE encoded, closes #7036 fix(core): rewrite `asset` protocol streaming, closes #6375 (#6390) closes #5939 (#5960) fix(core): use `safe_block_on` (#7047) closes #6859 (#6933) closes #6955 (#6998) fix(core): populate webview_attrs from config, closes #6794 (#6797) closes #5176 (#5180) fix: sound for notifications on windows (fix #6652) (#6680) close native window's buttons, closes #2353 (#6665) fix(bundler/nsis): calculate accurate app size, closes #7056 (#7057) fix(tests): only download update when it is available (#7061) closes #6706 (#6712) fix(doc): correct the doc of `content_protected()` (#7065) closes #6472 (#6530) fix(macros): use full path to Result to avoid issues with type aliases (#7071)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
Describe the bug
When supplying a custom fragment to add functionality to the Windows MSI installer created by tauri, attempting to use
WixUtilExtension
will make thelight.exe
invocation fail due to a duplicate argument.Reproduction
wxs
file from<Wix xmlns="http://schemas.microsoft.com/wix/2006/wi">
to<Wix xmlns="http://schemas.microsoft.com/wix/2006/wi" xmlns:util="http://schemas.microsoft.com/wix/UtilExtension">
cargo tauri build --verbose
Specifically, the WinUtilExtension got added twice to the list of arguments, as
-ext C:\Users\agersant\AppData\Local\tauri/WixTools\WixUtilExtension.dll
and also as-ext WixUtilExtension
.Expected behavior
Bundling completes with no error
Platform and versions
Stack trace
No response
Additional context
No response
The text was updated successfully, but these errors were encountered: