[Lang] MatrixType refactor part 2: add more ops #6425
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for docsite-preview ready!
To edit notification comments on pull requests, go to your Netlify site settings. |
strongoier
added a commit
that referenced
this pull request
Oct 26, 2022
Issue: #5819 ### Brief Summary A slice actually corresponds to several indices. Let's take a look at the following example: ```python import taichi as ti ti.init(real_matrix=True, real_matrix_scalarize=True, print_ir=True) @ti.kernel def foo(): c = ti.Vector([1, 2, 3, 4, 5]) print(c[:4:2]) foo() ``` `c[:4:2]` is a "partially selected vector with length 2" which contains references to `c[0]` and `c[2]`. Let's represent it with `c[(0), (2), shape=2]`. This PR does the following: - expands slices into groups of indices in Python; - extends `IndexExpression` to accept a group of indices; - creates `MatrixOfMatrixPtrStmt` to represent a "partially selected matrix" in CHI IR; - eliminates `MatrixOfMatrixPtrStmt` in the `lower_matrix_ptr()` pass. Frontend IR and CHI IR of the above example: ``` [I 10/25/22 19:54:51.885 816603] [compile_to_offloads.cpp:operator()@22] [foo_c80_0] Initial IR: kernel { $0 = alloca @tmp0 @tmp0 = [1, 2, 3, 4, 5] (dt=[Tensor (5) i32]) $2 = alloca @TMP1 @TMP1 = @tmp0 print @TMP1[(0), (2), shape=(2)], "\n" } [I 10/25/22 19:54:51.885 816603] [compile_to_offloads.cpp:operator()@22] [foo_c80_0] Lowered: kernel { <[Tensor (5) i32]> $0 = alloca <i32> $1 = const 1 <i32> $2 = const 2 <i32> $3 = const 3 <i32> $4 = const 4 <i32> $5 = const 5 <[Tensor (5) i32]> $6 = [$1, $2, $3, $4, $5] $7 : local store [$0 <- $6] <[Tensor (5) i32]> $8 = alloca $9 = local load [$0] $10 : local store [$8 <- $9] <i32> $11 = const 0 <*i32> $12 = shift ptr [$8 + $11] <i32> $13 = const 2 <*i32> $14 = shift ptr [$8 + $13] <[Tensor (2) i32]> $15 = matrix of matrix ptr [$12, $14] $16 = local load [$15] print $16, "\n" } ``` Some tests of matrix slice haven't been enabled yet because they require `x.transpose()`, which depends on #6425. Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com> Co-authored-by: Zhanlue Yang <[email protected]>
AD1024
changed the title
AD1024
changed the title
strongoier
reviewed
Oct 31, 2022
jim19930609
reviewed
Oct 31, 2022
jim19930609
reviewed
Nov 3, 2022
Co-authored-by: Zhanlue Yang <[email protected]>
strongoier
added a commit
that referenced
this pull request
Nov 7, 2022
strongoier
added a commit
that referenced
this pull request
Nov 12, 2022
### Brief Summary Foreach check in PR #6425 is verbose. This PR simplifies the usage. Co-authored-by: Yi Xu <[email protected]>
quadpixels
pushed a commit
to quadpixels/taichi
that referenced
this pull request
May 13, 2023
Issue: taichi-dev#5819 ### Brief Summary This PR only contains the valid case and a corresponding test. More comprehensive tests will be enabled once taichi-dev#6425 is in. Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
quadpixels
pushed a commit
to quadpixels/taichi
that referenced
this pull request
May 13, 2023
Issue: taichi-dev#5478 taichi-dev#5819 ### Brief Summary Co-authored-by: Yi Xu <[email protected]> Co-authored-by: Zhanlue Yang <[email protected]>
quadpixels
pushed a commit
to quadpixels/taichi
that referenced
this pull request
May 13, 2023
Issue: taichi-dev#5819 ### Brief Summary The use of atomic ops in taichi-dev#6425 is unnecessary. This PR removes those usage and simplifies logic around reduction ops.
quadpixels
pushed a commit
to quadpixels/taichi
that referenced
this pull request
May 13, 2023
### Brief Summary Foreach check in PR taichi-dev#6425 is verbose. This PR simplifies the usage. Co-authored-by: Yi Xu <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue: #5478 #5819
Brief Summary