Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[lang] Add fused foreach check #6525

Merged
merged 7 commits into from
Nov 12, 2022
Merged

Conversation

AD1024
Copy link
Contributor

@AD1024 AD1024 commented Nov 6, 2022

Brief Summary

Foreach check in PR #6425 is verbose. This PR simplifies the usage.

@netlify
Copy link

netlify bot commented Nov 6, 2022

Deploy Preview for docsite-preview ready!

Name Link
🔨 Latest commit 80d733d
🔍 Latest deploy log https://app.netlify.com/sites/docsite-preview/deploys/636eb2f481f33e0009b5cff4
😎 Deploy Preview https://deploy-preview-6525--docsite-preview.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@AD1024 AD1024 added the full-ci Run complete set of CI tests label Nov 6, 2022
@AD1024
Copy link
Contributor Author

AD1024 commented Nov 6, 2022

Note: in the discussion of #6425, we mentioned and and not logic, but the real blocker is or since we need a separate implementation to do or check, while the other two can be done sequentially or simply negating one of the checker funcs.

@AD1024 AD1024 changed the title [lang] add fused foreach check [lang] Add fused foreach check Nov 6, 2022
@strongoier strongoier merged commit 9665e88 into taichi-dev:master Nov 12, 2022
quadpixels pushed a commit to quadpixels/taichi that referenced this pull request May 13, 2023
### Brief Summary

Foreach check in PR taichi-dev#6425 is verbose. This PR simplifies the usage.

Co-authored-by: Yi Xu <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
full-ci Run complete set of CI tests
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants