Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[lang] MatrixType refactor: Support vector swizzle #6506

Merged
merged 4 commits into from
Nov 3, 2022

Conversation

strongoier
Copy link
Contributor

Issue: #5819

Brief Summary

This PR only contains the valid case and a corresponding test. More comprehensive tests will be enabled once #6425 is in.

@netlify
Copy link

netlify bot commented Nov 2, 2022

Deploy Preview for docsite-preview ready!

Name Link
🔨 Latest commit bb37323
🔍 Latest deploy log https://app.netlify.com/sites/docsite-preview/deploys/63628a487abf360008064f27
😎 Deploy Preview https://deploy-preview-6506--docsite-preview.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

Copy link
Contributor

@jim19930609 jim19930609 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

@strongoier strongoier merged commit 10dd56b into taichi-dev:master Nov 3, 2022
@strongoier strongoier deleted the mat-19 branch November 3, 2022 08:39
quadpixels pushed a commit to quadpixels/taichi that referenced this pull request May 13, 2023
Issue: taichi-dev#5819

### Brief Summary

This PR only contains the valid case and a corresponding test. More
comprehensive tests will be enabled once taichi-dev#6425 is in.

Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants