Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Example 22 broken after PR #6425 #6600

Closed
neozhaoliang opened this issue Nov 15, 2022 · 0 comments · Fixed by #6613
Closed

Example 22 broken after PR #6425 #6600

neozhaoliang opened this issue Nov 15, 2022 · 0 comments · Fixed by #6613
Labels
potential bug Something that looks like a bug but not yet confirmed

Comments

@neozhaoliang
Copy link
Contributor

neozhaoliang commented Nov 15, 2022 •
edited
Loading

After this PR #6425, the example 22 "Karman vortex street" is broken, this example still runs but the animation doesn't show correctly. And there is a warning in the matrix_ops.py:

[W 11/15/22 10:35:10.035 2582858] [type_check.cpp:type_check_store@36] [$32852] Atomic add may lose precision: i32 <- f32
File "/home/zhao/taichi/python/taichi/lang/matrix_ops.py", line 347, in _matmul_helper:
                result[i] += x[i, j] * y[j]
                ^^^^^^^^^^^^^^^^^^^^^^^^^^^

The parent commit does not have this problem.
@neozhaoliang neozhaoliang added the potential bug Something that looks like a bug but not yet confirmed label Nov 15, 2022
@taichi-gardener taichi-gardener moved this to Untriaged in Taichi Lang Nov 15, 2022
@strongoier strongoier mentioned this issue Nov 15, 2022
Merged
strongoier added a commit that referenced this issue Nov 17, 2022
@strongoier @pre-commit-ci
[lang] MatrixType bug fix: Fix result type of matmul (#6613)
0c4d896 
Issue: #5819, fix #6600

### Brief Summary

This PR also refactors the implementation of `matmul`, `fill` and `diag`
a bit. Now `matmul` of two vectors will return a scalar just as numpy
does, and `fill` will not have a return value.

Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
Repository owner moved this from Untriaged to Done in Taichi Lang Nov 17, 2022
quadpixels pushed a commit to quadpixels/taichi that referenced this issue May 13, 2023
@strongoier @pre-commit-ci @quadpixels
[lang] MatrixType bug fix: Fix result type of matmul (taichi-dev#6613)
5fb0358 
Issue: taichi-dev#5819, fix taichi-dev#6600

### Brief Summary

This PR also refactors the implementation of `matmul`, `fill` and `diag`
a bit. Now `matmul` of two vectors will return a scalar just as numpy
does, and `fill` will not have a return value.

Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
potential bug Something that looks like a bug but not yet confirmed
Projects
Taichi Lang
Status: Done
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

[lang] MatrixType bug fix: Fix result type of matmul strongoier/taichi
1 participant
@neozhaoliang