Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Git: catch up fe release #1722

Merged
merged 40 commits into from
Jan 3, 2024
Merged

Git: catch up fe release #1722

merged 40 commits into from
Jan 3, 2024

Conversation

ChiTimesChi
Copy link
Collaborator

@ChiTimesChi ChiTimesChi commented Dec 29, 2023

Description

This PR catches up fe-release with progress that have been committed to master branch only.

Additional context

See #1721 for the merging spproach
3b42dc90626b3cf58747c82de54f5bb8107c8672: synapse-interface preview link
2476d150d0982f383965cc8252014d28e11a613e: explorer-ui preview link
2476d150d0982f383965cc8252014d28e11a613e: synapse-interface preview link

ChiTimesChi and others added 30 commits December 14, 2023 16:43
* Update wagmi to 1.4.12

* yarn install
* Add placeholder logic for new functions

* Chore: fix spelling

* Add tests with expected behavior

* Generalize bridgeModule -> RouterSet retrieval

* Add skeleton for the end implementation

* Implement ID / status for SynapseBridge

* CCTP status check

* Define behavior for destination CCTP tx

* SynapseCCTP: getBridgeID

* Add test for incorrect tx hash

* Check that transaction receipt is not null

* Tests for generalized "incorrect origin tx" behavior

* Generalized tool for log extraction

* Adapt synapseCCTP, add check to synapseBridge

* Chore: bridgeId -> synapseTxId

* Extra coverage to keep Code Rabbi happy
 - @synapsecns/[email protected]
 - @synapsecns/[email protected]
 - @synapsecns/[email protected]

---------

Co-authored-by: Trajan0x <[email protected]>
Co-authored-by: coderabbitai[bot] <136622811+coderabbitai[bot]@users.noreply.github.com>
 - @synapsecns/[email protected]
 - @synapsecns/[email protected]
 - @synapsecns/[email protected]
* Check returned message value

* Add tests for bridging native gas tokens

* Fix: correct tx.value in `bridge()` and `swap()`

* Chore: cleanup
* Module: generalize Bridge/CCTP/RFQ

* ModuleSet: generalize Bridge/CCTP/RFQ sets

* Generalize chainId -> Module mapping

* Move tx status functions to ModuleSet

* Use bridgeModuleName in internal BridgeRoute

* Move types around
 - @synapsecns/[email protected]
 - @synapsecns/[email protected]
 - @synapsecns/[email protected]
* Chore: clean up promise resolution

* Fix excludeCCTP flag tests
 - @synapsecns/[email protected]
 - @synapsecns/[email protected]
 - @synapsecns/[email protected]
* Move dotenv to dev deps

* Don't expose test values in ./constants

* Update imports

* [REVERT IN PROD] use local SDK

* Revert "[REVERT IN PROD] use local SDK"

This reverts commit be9f0c0.

---------

Co-authored-by: ChiTimesChi <[email protected]>
 - @synapsecns/[email protected]
 - @synapsecns/[email protected]
 - @synapsecns/[email protected]
* Generate bindings using latest TypeChain

* Add FastBridge ABI
 - @synapsecns/[email protected]
 - @synapsecns/[email protected]
 - @synapsecns/[email protected]
Co-authored-by: Trajan0x <[email protected]>
* Add `modifyDeadline()` for Query

* Add `applySlippage()` for Query

* Add `allBridgeQuotes`

* Add tests for `allBridgeQuotes`

* Sort `allBridgeQuotes` by amountOut

* Simplify `bridgeQuote()`

* Add `applySlippageInBips`

* Expose "apply slippage" funcs

* Add tests for "apply slippage" not modifying the passed object

* Fix: don't modify `query` in test setups
 - @synapsecns/[email protected]
 - @synapsecns/[email protected]
 - @synapsecns/[email protected]
* allRouterSets -> allModuleSets

* Use `.find()` for getting the Module Set

* Simplify routerAddress -> module mapping

* Move `finalizeBridgeRoute` to `ModuleSet`

* calculateDeadline -> applyOptionalDeadline

* Use different default periods for modules
 - @synapsecns/[email protected]
 - @synapsecns/[email protected]
 - @synapsecns/[email protected]
Copy link
Contributor

coderabbitai bot commented Dec 29, 2023

Important

Auto Review Skipped

Auto reviews are disabled on base/target branches other than the default branch. Please add the base/target branch pattern to the list of additional branches to be reviewed in the settings.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository.

To trigger a single review, invoke the @coderabbitai review command.

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

Share

Tips

Chat with CodeRabbit Bot (@coderabbitai)

  • You can directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>.
    • Generate unit-tests for this file.
  • You can tag CodeRabbit on specific lines of code or entire files in the PR by tagging @coderabbitai in a comment. Examples:
    • @coderabbitai generate unit tests for this file.
    • @coderabbitai modularize this function.
  • You can tag @coderabbitai in a PR comment and ask questions about the PR and the codebase. Examples:
    • @coderabbitai generate interesting stats about this repository from git and render them as a table.
    • @coderabbitai show all the console.log statements in this repository.
    • @coderabbitai read src/utils.ts and generate unit tests.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid.
    • @coderabbitai read the files in the src/scheduler package and generate README in the markdown format.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks.

CodeRabbit Commands (invoked as PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger a review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai help to get help.

Additionally, you can add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.

CodeRabbit Configration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • The JSON schema for the configuration file is available here.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/coderabbit-overrides.v2.json

CodeRabbit Discord Community

Join our Discord Community to get help, request features, and share feedback.

* Add new section, general workflow

* Docs: contributing for a new feature

* Docs: releasing the new front-end build

* Docs: hotfixing the FE

* Use an advanced AI tool to enhance the author's presentation of intelligence
@github-actions github-actions bot added go Pull requests that update Go code M-explorer-ui labels Jan 3, 2024
@ChiTimesChi ChiTimesChi marked this pull request as ready for review January 3, 2024 16:31
Copy link

codecov bot commented Jan 3, 2024

Codecov Report

Attention: 88 lines in your changes are missing coverage. Please review.

Comparison is base (c17f2a2) 51.91344% compared to head (651ac00) 51.82736%.

Files Patch % Lines
...rvices/explorer/consumer/parser/tokendata/cache.go 2.63158% 70 Missing and 4 partials ⚠️
services/explorer/consumer/parser/cctpparser.go 0.00000% 14 Missing ⚠️
Additional details and impacted files
@@                 Coverage Diff                  @@
##           fe-release       #1722         +/-   ##
====================================================
- Coverage    51.91344%   51.82736%   -0.08609%     
====================================================
  Files             375         372          -3     
  Lines           25739       25556        -183     
  Branches          288         285          -3     
====================================================
- Hits            13362       13245        -117     
+ Misses          11074       11003         -71     
- Partials         1303        1308          +5     
Flag Coverage Δ
agents 47.44950% <100.00000%> (+0.00898%) ⬆️
cctp-relayer 63.00863% <ø> (ø)
core 64.09728% <ø> (+5.61496%) ⬆️
ethergo 58.75675% <ø> (-2.15895%) ⬇️
explorer 24.80881% <2.22222%> (-0.62344%) ⬇️
git-changes-action 53.94265% <ø> (ø)
omnirpc 53.19635% <ø> (ø)
packages 92.01065% <100.00000%> (+0.62646%) ⬆️
promexporter 73.80952% <ø> (ø)
release-copier-action 19.33333% <ø> (ø)
scribe 52.02703% <ø> (ø)
sinner 64.60481% <ø> (ø)
tools 21.72452% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@ChiTimesChi ChiTimesChi merged commit 4655ec1 into fe-release Jan 3, 2024
62 checks passed
@ChiTimesChi ChiTimesChi deleted the git/catch-up-fe-release branch January 3, 2024 22:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants