Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

remove tunnel functionality #1688

Merged
merged 1 commit into from
Dec 21, 2023
Merged

remove tunnel functionality #1688

merged 1 commit into from
Dec 21, 2023

Conversation

trajan0x
Copy link
Contributor

@trajan0x trajan0x commented Dec 21, 2023

Description

Remove unused tunneling functionality

Issue came up in #1684 as a result of ngrok changing some apis.

This functionality is not used/was never used anyway

This does not affect any IAP related tunneling

@github-actions github-actions bot added go Pull requests that update Go code size/m labels Dec 21, 2023
Copy link

codecov bot commented Dec 21, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (530cf51) 51.78046% compared to head (dd38809) 52.27068%.

Additional details and impacted files
@@                 Coverage Diff                 @@
##              master       #1688         +/-   ##
===================================================
+ Coverage   51.78046%   52.27068%   +0.49022%     
===================================================
  Files            376         370          -6     
  Lines          25836       25521        -315     
  Branches         288         288                 
===================================================
- Hits           13378       13340         -38     
+ Misses         11152       10881        -271     
+ Partials        1306        1300          -6     
Flag Coverage Δ
cctp-relayer 63.00863% <ø> (ø)
core 64.22094% <ø> (+5.73863%) ⬆️
ethergo 60.27047% <ø> (+0.12793%) ⬆️
git-changes-action 53.94265% <ø> (ø)
omnirpc 53.19635% <ø> (ø)
promexporter 73.80952% <ø> (ø)
release-copier-action 19.33333% <ø> (ø)
scribe 52.02703% <ø> (ø)
sinner 64.60481% <ø> (ø)
tools 21.72452% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@trajan0x trajan0x merged commit 09bd330 into master Dec 21, 2023
56 of 59 checks passed
@trajan0x trajan0x deleted the trim/tunnel branch December 21, 2023 06:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
go Pull requests that update Go code size/m
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant