Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix failing test (not enough pool liquidity) #1690

Merged
merged 1 commit into from
Dec 21, 2023
Merged

Conversation

ChiTimesChi
Copy link
Collaborator

@ChiTimesChi ChiTimesChi commented Dec 21, 2023

Description
Some of the fork tests were failing due to not enough external liquidity for USDC.e/USDC on Arbitrum. This PR fixes that.

Summary by CodeRabbit

  • Tests
    • Updated descriptions and target currency in test cases from "USDC.e" to "USDT" for improved accuracy and clarity.

Copy link
Contributor

coderabbitai bot commented Dec 21, 2023

Walkthrough

The recent update entails revising test cases for the SynapseSDK by changing the descriptions and target currency from "ARB USDC.e" to "ARB USDT". These modifications are strictly textual and do not affect any exported or public entities.

Changes

File Path Change Summary
packages/.../sdk.test.ts Updated descriptions and target currency in test cases from "ARB USDC.e" to "ARB USDT".

🐇💻
In the land of code, where tests are spun,
A rabbit hopped, and changes were done.
From USDC.e to USDT we leap,
Ensuring the SDK's promises we keep. 🌟🎉

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on X ?


Tips

Chat with CodeRabbit Bot (@coderabbitai)

  • You can reply to a review comment made by CodeRabbit.
  • You can tag CodeRabbit on specific lines of code or files in the PR by tagging @coderabbitai in a comment.
  • You can tag @coderabbitai in a PR comment and ask one-off questions about the PR and the codebase. Use quoted replies to pass the context for follow-up questions.

CodeRabbit Commands (invoked as PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger a review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai help to get help.

Additionally, you can add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.

CodeRabbit Configration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • The JSON schema for the configuration file is available here.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/coderabbit-overrides.v2.json

Copy link
Contributor

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Review Status

Actionable comments generated: 0

Configuration used: CodeRabbit UI

Commits Files that changed from the base of the PR and between 09bd330 and fcbdc8c.
Files selected for processing (1)
  • packages/sdk-router/src/sdk.test.ts (3 hunks)
Files skipped from review due to trivial changes (1)
  • packages/sdk-router/src/sdk.test.ts

Copy link

codecov bot commented Dec 21, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (09bd330) 52.25892% compared to head (fcbdc8c) 51.79385%.

Additional details and impacted files
@@                 Coverage Diff                 @@
##              master       #1690         +/-   ##
===================================================
- Coverage   52.25892%   51.79385%   -0.46508%     
===================================================
  Files            370         358         -12     
  Lines          25521       24584        -937     
  Branches         288         288                 
===================================================
- Hits           13337       12733        -604     
+ Misses         10885       10617        -268     
+ Partials        1299        1234         -65     
Flag Coverage Δ
cctp-relayer ?
packages 91.38418% <ø> (ø)
promexporter ?

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@ChiTimesChi ChiTimesChi merged commit 8c7ea44 into master Dec 21, 2023
35 checks passed
@ChiTimesChi ChiTimesChi deleted the sdk/fix-fork-tests branch December 21, 2023 12:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant