-
Notifications
You must be signed in to change notification settings - Fork 32
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix failing test (not enough pool liquidity) #1690
Conversation
WalkthroughThe recent update entails revising test cases for the Changes
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on X ? TipsChat with CodeRabbit Bot (
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Review Status
Actionable comments generated: 0
Configuration used: CodeRabbit UI
Files selected for processing (1)
- packages/sdk-router/src/sdk.test.ts (3 hunks)
Files skipped from review due to trivial changes (1)
- packages/sdk-router/src/sdk.test.ts
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #1690 +/- ##
===================================================
- Coverage 52.25892% 51.79385% -0.46508%
===================================================
Files 370 358 -12
Lines 25521 24584 -937
Branches 288 288
===================================================
- Hits 13337 12733 -604
+ Misses 10885 10617 -268
+ Partials 1299 1234 -65
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
Description
Some of the fork tests were failing due to not enough external liquidity for USDC.e/USDC on Arbitrum. This PR fixes that.
Summary by CodeRabbit