Fix: signature V value

[dwasse]

Description
Fixes setting of V value in agent signatures.

Summary by CodeRabbit

• Refactor
  • Improved signature encoding process for enhanced security and reliability.

[coderabbitai]

Walkthrough

The update involves a refinement in the encoding of signatures within a Go utility function. By incorporating the math/big package, the function's logic for signature handling has been enhanced, resulting in a more sophisticated manipulation of the signature data before it is returned.

Changes

File Path	Change Summary
agents/types/utils.go	Introduced math/big package; refactored signEncoder function to transform the signature using math/big.

🐇✨
To code we hop, with every byte,
A sig refined, a leap of might.
Big math in play, the logic tight,
CodeRabbit's joy, in bits alight. 🚀🌟

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

Share

• X
• Mastodon
• Reddit
• LinkedIn

---

Tips

Chat with CodeRabbit Bot (@coderabbitai)

• You can directly reply to a review comment made by CodeRabbit. Example:
  • I pushed a fix in commit <commit_id>.
  • Generate unit-tests for this file.
• You can tag CodeRabbit on specific lines of code or entire files in the PR by tagging @coderabbitai in a comment. Examples:
  • @coderabbitai generate unit tests for this file.
  • @coderabbitai modularize this function.
• You can tag @coderabbitai in a PR comment and ask questions about the PR and the codebase. Examples:
  • @coderabbitai generate interesting stats about this repository from git and render them as a table.
  • @coderabbitai show all the console.log statements in this repository.
  • @coderabbitai read src/utils.ts and generate unit tests.
  • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid.
  • @coderabbitai read the files in the src/scheduler package and generate README in the markdown format.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks.

CodeRabbit Commands (invoked as PR comments)

• @coderabbitai pause to pause the reviews on a PR.
• @coderabbitai resume to resume the paused reviews.
• @coderabbitai review to trigger a review. This is useful when automatic reviews are disabled for the repository.
• @coderabbitai resolve resolve all the CodeRabbit review comments.
• @coderabbitai help to get help.

Additionally, you can add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.

CodeRabbit Configration File (.coderabbit.yaml)

• You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
• The JSON schema for the configuration file is available here.
• If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/coderabbit-overrides.v2.json

CodeRabbit Discord Community

Join our Discord Community to get help, request features, and share feedback.

[coderabbitai]

Review Status

Actionable comments generated: 0

Configuration used: CodeRabbit UI

Commits

Files that changed from the base of the PR and between f14f58a and fe55fca.

Files selected for processing (1)

• agents/types/utils.go (2 hunks)

Additional comments: 4

agents/types/utils.go (4)

• 6-6: The addition of the math/big package is appropriate for handling large numbers in cryptographic operations.

• 31-31: Renaming the variable signature to sig is a minor change and does not affect the logic of the function.

• 36-36: The adjustment to the V value in the signature by adding 27 is a specific cryptographic operation that should be verified for correctness according to the signature algorithm's requirements.

• 36-37: Creating a new signature with the adjusted V value using math/big should be secure, but it's important to ensure that this change does not introduce any vulnerabilities or deviations from best practices in cryptographic operations.

[codecov]

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (513723b) 51.42996% compared to head (fe55fca) 51.43588%.
Report is 1 commits behind head on master.

Additional details and impacted files

@@                 Coverage Diff                 @@
##              master       #1720         +/-   ##
===================================================
+ Coverage   51.42996%   51.43588%   +0.00591%     
===================================================
  Files            360         360                 
  Lines          24616       24619          +3     
  Branches         285         285                 
===================================================
+ Hits           12660       12663          +3     
+ Misses         10722       10718          -4     
- Partials        1234        1238          +4     

Flag	Coverage Δ
agents	47.44950% <100.00000%> (+0.02700%)	⬆️
sinner	64.60481% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.