Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

sync fe #1713

Closed
wants to merge 30 commits into from
Closed

sync fe #1713

wants to merge 30 commits into from

Conversation

aureliusbtc
Copy link
Contributor

Description
A clear and concise description of the features you're adding in this pull request.

Additional context
Add any other context about the problem you're solving.

Metadata

  • Fixes #[Link to Issue]

ChiTimesChi and others added 22 commits December 14, 2023 16:43
@ChiTimesChi
Fix/update wagmi main (#1665)
ba6ce85 
* Update wagmi to 1.4.12

* yarn install
@ChiTimesChi
Publish
ef037ad 
 - @synapsecns/[email protected]
@ChiTimesChi
Sdk: expose bridge tx status (#1658)
2e9e93f 
* Add placeholder logic for new functions

* Chore: fix spelling

* Add tests with expected behavior

* Generalize bridgeModule -> RouterSet retrieval

* Add skeleton for the end implementation

* Implement ID / status for SynapseBridge

* CCTP status check

* Define behavior for destination CCTP tx

* SynapseCCTP: getBridgeID

* Add test for incorrect tx hash

* Check that transaction receipt is not null

* Tests for generalized "incorrect origin tx" behavior

* Generalized tool for log extraction

* Adapt synapseCCTP, add check to synapseBridge

* Chore: bridgeId -> synapseTxId

* Extra coverage to keep Code Rabbi happy
@ChiTimesChi
Publish
77e6efb 
 - @synapsecns/[email protected]
 - @synapsecns/[email protected]
 - @synapsecns/[email protected]
@trajan0x @coderabbitai
Updates Submitter w/ Oracle fallback (#1671)
530cf51 

---------

Co-authored-by: Trajan0x <[email protected]>
Co-authored-by: coderabbitai[bot] <136622811+coderabbitai[bot]@users.noreply.github.com>
@trajan0x
remove tunnel functionality (#1688)
09bd330 
Co-authored-by: Trajan0x <[email protected]>
@ChiTimesChi
Fix failing test (not enough pool liquidity) (#1690)
8c7ea44
@ChiTimesChi
Publish
c305a20 
 - @synapsecns/[email protected]
 - @synapsecns/[email protected]
 - @synapsecns/[email protected]
@trajan0x
remove tunnel from readme (#1692)
4720c5d 
Co-authored-by: Trajan0x <[email protected]>
@ChiTimesChi
SDK: fix native value (#1683)
9238568 
* Check returned message value

* Add tests for bridging native gas tokens

* Fix: correct tx.value in `bridge()` and `swap()`

* Chore: cleanup
@ChiTimesChi
SDK: generalize modules (#1691)
68e8495 
* Module: generalize Bridge/CCTP/RFQ

* ModuleSet: generalize Bridge/CCTP/RFQ sets

* Generalize chainId -> Module mapping

* Move tx status functions to ModuleSet

* Use bridgeModuleName in internal BridgeRoute

* Move types around
@ChiTimesChi
Publish
1ed8c43 
 - @synapsecns/[email protected]
 - @synapsecns/[email protected]
 - @synapsecns/[email protected]
@ChiTimesChi
SDK: fix exclude cctp tests (#1702)
61947fe 
* Chore: clean up promise resolution

* Fix excludeCCTP flag tests
@ChiTimesChi
Publish
d5aff40 
 - @synapsecns/[email protected]
 - @synapsecns/[email protected]
 - @synapsecns/[email protected]
@bigboydiamonds @ChiTimesChi
Move dotenv to dev deps (#1696)
f14a22a 
* Move dotenv to dev deps

* Don't expose test values in ./constants

* Update imports

* [REVERT IN PROD] use local SDK

* Revert "[REVERT IN PROD] use local SDK"

This reverts commit be9f0c0.

---------

Co-authored-by: ChiTimesChi <[email protected]>
@ChiTimesChi
Publish
9a5ef7e 
 - @synapsecns/[email protected]
 - @synapsecns/[email protected]
 - @synapsecns/[email protected]
@ChiTimesChi
SDK: update bindings (#1706)
5d3d387 
* Generate bindings using latest TypeChain

* Add FastBridge ABI
@ChiTimesChi
Publish
45ab6d6 
 - @synapsecns/[email protected]
 - @synapsecns/[email protected]
 - @synapsecns/[email protected]
@bsgrigorov
Updated explorer indexer for migration (#1685)
ef79e78
@trajan0x
Revert "Updates Submitter w/ Oracle fallback (#1671)" (#1709)
66e4c25 
This reverts commit 530cf51.
@aureliusbtc
update
a96ebb3
@aureliusbtc
Merge pull request #1712 from synapsecns/fe/update-lists
2e943a2 
update list
@coderabbitai coderabbitai
Copy link
Contributor

coderabbitai bot commented Dec 25, 2023 •
edited
Loading

Important

Auto Review Skipped

Auto reviews are disabled on base/target branches other than the default branch. Please add the base/target branch pattern to the list of additional branches to be reviewed in the settings.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository.

To trigger a single review, invoke the @coderabbitai review command.

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

Share
Tips

Chat with CodeRabbit Bot (@coderabbitai)

  • You can directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>.
    • Generate unit-tests for this file.
  • You can tag CodeRabbit on specific lines of code or entire files in the PR by tagging @coderabbitai in a comment. Examples:
    • @coderabbitai generate unit tests for this file.
    • @coderabbitai modularize this function.
  • You can tag @coderabbitai in a PR comment and ask questions about the PR and the codebase. Examples:
    • @coderabbitai generate interesting stats about this repository from git and render them as a table.
    • @coderabbitai show all the console.log statements in this repository.
    • @coderabbitai read src/utils.ts and generate unit tests.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid.
    • @coderabbitai read the files in the src/scheduler package and generate README in the markdown format.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks.

CodeRabbit Commands (invoked as PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger a review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai help to get help.

Additionally, you can add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.

CodeRabbit Configration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • The JSON schema for the configuration file is available here.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/coderabbit-overrides.v2.json

CodeRabbit Discord Community

Join our Discord Community to get help, request features, and share feedback.

@github-actions github-actions bot added the go Pull requests that update Go code label Dec 25, 2023
aureliusbtc and others added 8 commits December 25, 2023 14:04
@aureliusbtc
Publish
977cbb4 
 - @synapsecns/[email protected]
@trajan0x
lint fix (#1715)
e7cfd5d 
Co-authored-by: Trajan0x <[email protected]>
@trajan0x
Publish
225e70a 
 - @synapsecns/[email protected]
@ChiTimesChi
SDK: all quotes, Query modifications (#1716)
b5bf2b5 
* Add `modifyDeadline()` for Query

* Add `applySlippage()` for Query

* Add `allBridgeQuotes`

* Add tests for `allBridgeQuotes`

* Sort `allBridgeQuotes` by amountOut

* Simplify `bridgeQuote()`

* Add `applySlippageInBips`

* Expose "apply slippage" funcs

* Add tests for "apply slippage" not modifying the passed object

* Fix: don't modify `query` in test setups
@ChiTimesChi
Publish
8d765e5 
 - @synapsecns/[email protected]
 - @synapsecns/[email protected]
 - @synapsecns/[email protected]
@ChiTimesChi
SDK: further generalize modules (#1717)
513723b 
* allRouterSets -> allModuleSets

* Use `.find()` for getting the Module Set

* Simplify routerAddress -> module mapping

* Move `finalizeBridgeRoute` to `ModuleSet`

* calculateDeadline -> applyOptionalDeadline

* Use different default periods for modules
@ChiTimesChi
Publish
f14f58a 
 - @synapsecns/[email protected]
 - @synapsecns/[email protected]
 - @synapsecns/[email protected]
@dwasse
Fix: attempt to fix v+27 (#1720)
b6d2349
@ChiTimesChi
Copy link
Collaborator

Closing as the amount of merge conflicts is huge - and also we don't want to merge stuff directly from master, as it will auto-delete the branch.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@trajan0x trajan0x Awaiting requested review from trajan0x trajan0x is a code owner

@nautsimon nautsimon Awaiting requested review from nautsimon

@bigboydiamonds bigboydiamonds Awaiting requested review from bigboydiamonds bigboydiamonds is a code owner

@abtestingalpha abtestingalpha Awaiting requested review from abtestingalpha abtestingalpha is a code owner

@Defi-Moses Defi-Moses Awaiting requested review from Defi-Moses Defi-Moses is a code owner

@ChiTimesChi ChiTimesChi Awaiting requested review from ChiTimesChi ChiTimesChi is a code owner

Assignees
No one assigned
Labels
go Pull requests that update Go code M-synapse-interface size/l
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@aureliusbtc @ChiTimesChi @trajan0x @bigboydiamonds @bsgrigorov @dwasse