Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: define search path in auth functions #1616

Merged
merged 1 commit into from
Jun 12, 2024
Merged

fix: define search path in auth functions #1616

merged 1 commit into from
Jun 12, 2024

Conversation

kangmingtay
Copy link
Member

What kind of change does this PR introduce?

  • Set search_path to empty string in all auth functions

@kangmingtay kangmingtay requested a review from a team as a code owner June 12, 2024 04:34
@coveralls
Copy link

coveralls commented Jun 12, 2024 •
edited
Loading

Pull Request Test Coverage Report for Build 9476776032

Details

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 57.589%
Totals Coverage Status
Change from base Build 9416552113: 0.0%
Covered Lines: 8507
Relevant Lines: 14772
💛 - Coveralls

J0
J0 approved these changes Jun 12, 2024
View reviewed changes
Copy link
Contributor

@J0 J0 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks!

@J0
Copy link
Contributor

J0 commented Jun 12, 2024 •
edited
Loading

Addenum for future reference:

  • Search path is local to the function so it doesn't affect anything outside of the function
  • In the modified functions (auth.jwt(), auth.uid(), etc) we only access functions which belong to pg_catalog which is implicitly searched so it should not affect the behaviour of the functions

@kangmingtay kangmingtay merged commit 357bda2 into master Jun 12, 2024
3 checks passed
@kangmingtay kangmingtay deleted the km/alter-auth-uid branch June 12, 2024 09:52
@github-actions github-actions bot mentioned this pull request Jun 12, 2024
Merged
J0 pushed a commit that referenced this pull request Jun 14, 2024
@github-actions
chore(master): release 2.154.0 (#1610)
3cd00ee 
🤖 I have created a release *beep* *boop*
---


##
[2.154.0](v2.153.0...v2.154.0)
(2024-06-12)


### Features

* add max length check for email
([#1508](#1508))
([f9c13c0](f9c13c0))
* add support for Slack OAuth V2
([#1591](#1591))
([bb99251](bb99251))
* encrypt sensitive columns
([#1593](#1593))
([e4a4758](e4a4758))
* upgrade otel to v1.26
([#1585](#1585))
([cdd13ad](cdd13ad))
* use largest avatar from spotify instead
([#1210](#1210))
([4f9994b](4f9994b)),
closes [#1209](#1209)


### Bug Fixes

* define search path in auth functions
([#1616](#1616))
([357bda2](357bda2))
* enable rls & update grants for auth tables
([#1617](#1617))
([28967aa](28967aa))

---
This PR was generated with [Release
Please](https://github.com/googleapis/release-please). See
[documentation](https://github.com/googleapis/release-please#release-please).

Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
J0 added a commit that referenced this pull request Jun 24, 2024
@J0
Revert "fix: define search path in auth functions (#1616)"
bdca080 
This reverts commit 357bda2.
@J0 J0 mentioned this pull request Jun 24, 2024
Merged
J0 added a commit that referenced this pull request Jun 24, 2024
@J0
fix: revert define search path in auth functions (#1634)
155e87e 
Reverts #1616

Follow up to #1633 - more context there and in this discussion:
https://supabase.slack.com/archives/C07A55TKL3S/p1719237535404369
uxodb pushed a commit to uxodb/auth that referenced this pull request Nov 13, 2024
@kangmingtay
fix: define search path in auth functions (supabase#1616)
36e80e2 
## What kind of change does this PR introduce?
* Set search_path to empty string in all auth functions
uxodb pushed a commit to uxodb/auth that referenced this pull request Nov 13, 2024
@github-actions
chore(master): release 2.154.0 (supabase#1610)
65fdd02 
🤖 I have created a release *beep* *boop*
---


##
[2.154.0](supabase/auth@v2.153.0...v2.154.0)
(2024-06-12)


### Features

* add max length check for email
([supabase#1508](supabase#1508))
([f9c13c0](supabase@f9c13c0))
* add support for Slack OAuth V2
([supabase#1591](supabase#1591))
([bb99251](supabase@bb99251))
* encrypt sensitive columns
([supabase#1593](supabase#1593))
([e4a4758](supabase@e4a4758))
* upgrade otel to v1.26
([supabase#1585](supabase#1585))
([cdd13ad](supabase@cdd13ad))
* use largest avatar from spotify instead
([supabase#1210](supabase#1210))
([4f9994b](supabase@4f9994b)),
closes [supabase#1209](supabase#1209)


### Bug Fixes

* define search path in auth functions
([supabase#1616](supabase#1616))
([357bda2](supabase@357bda2))
* enable rls & update grants for auth tables
([supabase#1617](supabase#1617))
([28967aa](supabase@28967aa))

---
This PR was generated with [Release
Please](https://github.com/googleapis/release-please). See
[documentation](https://github.com/googleapis/release-please#release-please).

Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
uxodb pushed a commit to uxodb/auth that referenced this pull request Nov 13, 2024
@J0
fix: revert define search path in auth functions (supabase#1634)
805ad0c 
Reverts supabase#1616

Follow up to supabase#1633 - more context there and in this discussion:
https://supabase.slack.com/archives/C07A55TKL3S/p1719237535404369
LashaJini pushed a commit to LashaJini/auth that referenced this pull request Nov 13, 2024
@kangmingtay @LashaJini
fix: define search path in auth functions (supabase#1616)
c7061b2 
## What kind of change does this PR introduce?
* Set search_path to empty string in all auth functions
LashaJini pushed a commit to LashaJini/auth that referenced this pull request Nov 13, 2024
@github-actions @LashaJini
chore(master): release 2.154.0 (supabase#1610)
9dbbed6 
🤖 I have created a release *beep* *boop*
---


##
[2.154.0](supabase/auth@v2.153.0...v2.154.0)
(2024-06-12)


### Features

* add max length check for email
([supabase#1508](supabase#1508))
([f9c13c0](supabase@f9c13c0))
* add support for Slack OAuth V2
([supabase#1591](supabase#1591))
([bb99251](supabase@bb99251))
* encrypt sensitive columns
([supabase#1593](supabase#1593))
([e4a4758](supabase@e4a4758))
* upgrade otel to v1.26
([supabase#1585](supabase#1585))
([cdd13ad](supabase@cdd13ad))
* use largest avatar from spotify instead
([supabase#1210](supabase#1210))
([4f9994b](supabase@4f9994b)),
closes [supabase#1209](supabase#1209)


### Bug Fixes

* define search path in auth functions
([supabase#1616](supabase#1616))
([357bda2](supabase@357bda2))
* enable rls & update grants for auth tables
([supabase#1617](supabase#1617))
([28967aa](supabase@28967aa))

---
This PR was generated with [Release
Please](https://github.com/googleapis/release-please). See
[documentation](https://github.com/googleapis/release-please#release-please).

Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
LashaJini pushed a commit to LashaJini/auth that referenced this pull request Nov 13, 2024
@J0 @LashaJini
fix: revert define search path in auth functions (supabase#1634)
692689c 
Reverts supabase#1616

Follow up to supabase#1633 - more context there and in this discussion:
https://supabase.slack.com/archives/C07A55TKL3S/p1719237535404369
LashaJini pushed a commit to LashaJini/auth that referenced this pull request Nov 15, 2024
@kangmingtay @LashaJini
fix: define search path in auth functions (supabase#1616)
66f8b03 
## What kind of change does this PR introduce?
* Set search_path to empty string in all auth functions
LashaJini pushed a commit to LashaJini/auth that referenced this pull request Nov 15, 2024
@github-actions @LashaJini
chore(master): release 2.154.0 (supabase#1610)
bb3cff5 
🤖 I have created a release *beep* *boop*
---


##
[2.154.0](supabase/auth@v2.153.0...v2.154.0)
(2024-06-12)


### Features

* add max length check for email
([supabase#1508](supabase#1508))
([f9c13c0](supabase@f9c13c0))
* add support for Slack OAuth V2
([supabase#1591](supabase#1591))
([bb99251](supabase@bb99251))
* encrypt sensitive columns
([supabase#1593](supabase#1593))
([e4a4758](supabase@e4a4758))
* upgrade otel to v1.26
([supabase#1585](supabase#1585))
([cdd13ad](supabase@cdd13ad))
* use largest avatar from spotify instead
([supabase#1210](supabase#1210))
([4f9994b](supabase@4f9994b)),
closes [supabase#1209](supabase#1209)


### Bug Fixes

* define search path in auth functions
([supabase#1616](supabase#1616))
([357bda2](supabase@357bda2))
* enable rls & update grants for auth tables
([supabase#1617](supabase#1617))
([28967aa](supabase@28967aa))

---
This PR was generated with [Release
Please](https://github.com/googleapis/release-please). See
[documentation](https://github.com/googleapis/release-please#release-please).

Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
LashaJini pushed a commit to LashaJini/auth that referenced this pull request Nov 15, 2024
@J0 @LashaJini
fix: revert define search path in auth functions (supabase#1634)
6595831 
Reverts supabase#1616

Follow up to supabase#1633 - more context there and in this discussion:
https://supabase.slack.com/archives/C07A55TKL3S/p1719237535404369
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@J0 J0 J0 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@kangmingtay @coveralls @J0