feat: upgrade otel to v1.26 #1585

J0 · 2024-05-21T15:01:21Z

What kind of change does this PR introduce?

Spiritual successor to #1305 where we attempt to bump the OTEL version from v1.10.0 to v1.26.0 which has a few breaking changes

How this was tested

We used a local setup with honeycomb with tracing and metrics enabled. We then triggered

a cleanup to test gotrue_cleanup_affected_rows
a few password sign ins to test gotrue_compare_hash_and_password_submitted
Checked if gotrue_running was present
Checked that DB traces were still present

DB Trace:

Metrics:

coveralls · 2024-05-22T12:34:09Z

Pull Request Test Coverage Report for Build 9416496963

Details

21 of 79 (26.58%) changed or added relevant lines in 5 files are covered.
No unchanged relevant lines lost coverage.
Overall coverage increased (+0.03%) to 57.589%

Changes Missing Coverage	Covered Lines	Changed/Added Lines	%
internal/models/cleanup.go	6	9	66.67%
internal/observability/request-tracing.go	5	8	62.5%
internal/observability/metrics.go	3	55	5.45%

Totals
Change from base Build 9404687053:	0.03%
Covered Lines:	8507
Relevant Lines:	14772

💛 - Coveralls

internal/api/opentelemetry-tracer_test.go

internal/models/cleanup.go

internal/observability/metrics.go

internal/api/middleware.go

internal/models/cleanup.go

hf

Looks good to me at a first glance. If they end up in Honeycomb and the Prometheus server is serving up pretty-much the same metrics as before, address the comments from @kangmingtay and merge I guess.

kangmingtay · 2024-06-04T08:01:15Z

nice work! feel free to resolve the comments and merge 👍

J0 · 2024-06-06T12:56:59Z

Will merge in the evening, after some final sanity checks

J0 · 2024-06-06T21:15:55Z

Might have to delay this to the morning, having slight issues pulling on the internet connection where I'm at.

🤖 I have created a release *beep* *boop* --- ## [2.154.0](v2.153.0...v2.154.0) (2024-06-12) ### Features * add max length check for email ([#1508](#1508)) ([f9c13c0](f9c13c0)) * add support for Slack OAuth V2 ([#1591](#1591)) ([bb99251](bb99251)) * encrypt sensitive columns ([#1593](#1593)) ([e4a4758](e4a4758)) * upgrade otel to v1.26 ([#1585](#1585)) ([cdd13ad](cdd13ad)) * use largest avatar from spotify instead ([#1210](#1210)) ([4f9994b](4f9994b)), closes [#1209](#1209) ### Bug Fixes * define search path in auth functions ([#1616](#1616)) ([357bda2](357bda2)) * enable rls & update grants for auth tables ([#1617](#1617)) ([28967aa](28967aa)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please). Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>

## What kind of change does this PR introduce? Spiritual successor to supabase#1305 where we attempt to bump the OTEL version from v1.10.0 to v1.26.0 which has a few breaking changes ## How this was tested We used a local setup with honeycomb with tracing and metrics enabled. We then triggered - a cleanup to test `gotrue_cleanup_affected_rows` - a few password sign ins to test `gotrue_compare_hash_and_password_submitted` - Checked if `gotrue_running` was present - Checked that DB traces were still present DB Trace: <img width="1108" alt="CleanShot 2024-05-23 at 20 46 02@2x" src="https://github.com/supabase/auth/assets/8011761/a365badb-08c3-4184-aef8-83624082d08d"> Metrics: <img width="1064" alt="CleanShot 2024-05-23 at 20 41 51@2x" src="https://github.com/supabase/auth/assets/8011761/1fc7743e-fc87-42a1-bf11-d14c739d5b67">

🤖 I have created a release *beep* *boop* --- ## [2.154.0](supabase/auth@v2.153.0...v2.154.0) (2024-06-12) ### Features * add max length check for email ([supabase#1508](supabase#1508)) ([f9c13c0](supabase@f9c13c0)) * add support for Slack OAuth V2 ([supabase#1591](supabase#1591)) ([bb99251](supabase@bb99251)) * encrypt sensitive columns ([supabase#1593](supabase#1593)) ([e4a4758](supabase@e4a4758)) * upgrade otel to v1.26 ([supabase#1585](supabase#1585)) ([cdd13ad](supabase@cdd13ad)) * use largest avatar from spotify instead ([supabase#1210](supabase#1210)) ([4f9994b](supabase@4f9994b)), closes [supabase#1209](supabase#1209) ### Bug Fixes * define search path in auth functions ([supabase#1616](supabase#1616)) ([357bda2](supabase@357bda2)) * enable rls & update grants for auth tables ([supabase#1617](supabase#1617)) ([28967aa](supabase@28967aa)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please). Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>

## What kind of change does this PR introduce? Spiritual successor to supabase#1305 where we attempt to bump the OTEL version from v1.10.0 to v1.26.0 which has a few breaking changes ## How this was tested We used a local setup with honeycomb with tracing and metrics enabled. We then triggered - a cleanup to test `gotrue_cleanup_affected_rows` - a few password sign ins to test `gotrue_compare_hash_and_password_submitted` - Checked if `gotrue_running` was present - Checked that DB traces were still present DB Trace: <img width="1108" alt="CleanShot 2024-05-23 at 20 46 02@2x" src="https://github.com/supabase/auth/assets/8011761/a365badb-08c3-4184-aef8-83624082d08d"> Metrics: <img width="1064" alt="CleanShot 2024-05-23 at 20 41 51@2x" src="https://github.com/supabase/auth/assets/8011761/1fc7743e-fc87-42a1-bf11-d14c739d5b67">

🤖 I have created a release *beep* *boop* --- ## [2.154.0](supabase/auth@v2.153.0...v2.154.0) (2024-06-12) ### Features * add max length check for email ([supabase#1508](supabase#1508)) ([f9c13c0](supabase@f9c13c0)) * add support for Slack OAuth V2 ([supabase#1591](supabase#1591)) ([bb99251](supabase@bb99251)) * encrypt sensitive columns ([supabase#1593](supabase#1593)) ([e4a4758](supabase@e4a4758)) * upgrade otel to v1.26 ([supabase#1585](supabase#1585)) ([cdd13ad](supabase@cdd13ad)) * use largest avatar from spotify instead ([supabase#1210](supabase#1210)) ([4f9994b](supabase@4f9994b)), closes [supabase#1209](supabase#1209) ### Bug Fixes * define search path in auth functions ([supabase#1616](supabase#1616)) ([357bda2](supabase@357bda2)) * enable rls & update grants for auth tables ([supabase#1617](supabase#1617)) ([28967aa](supabase@28967aa)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please). Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>

## What kind of change does this PR introduce? Spiritual successor to supabase#1305 where we attempt to bump the OTEL version from v1.10.0 to v1.26.0 which has a few breaking changes ## How this was tested We used a local setup with honeycomb with tracing and metrics enabled. We then triggered - a cleanup to test `gotrue_cleanup_affected_rows` - a few password sign ins to test `gotrue_compare_hash_and_password_submitted` - Checked if `gotrue_running` was present - Checked that DB traces were still present DB Trace: <img width="1108" alt="CleanShot 2024-05-23 at 20 46 02@2x" src="https://github.com/supabase/auth/assets/8011761/a365badb-08c3-4184-aef8-83624082d08d"> Metrics: <img width="1064" alt="CleanShot 2024-05-23 at 20 41 51@2x" src="https://github.com/supabase/auth/assets/8011761/1fc7743e-fc87-42a1-bf11-d14c739d5b67">

🤖 I have created a release *beep* *boop* --- ## [2.154.0](supabase/auth@v2.153.0...v2.154.0) (2024-06-12) ### Features * add max length check for email ([supabase#1508](supabase#1508)) ([f9c13c0](supabase@f9c13c0)) * add support for Slack OAuth V2 ([supabase#1591](supabase#1591)) ([bb99251](supabase@bb99251)) * encrypt sensitive columns ([supabase#1593](supabase#1593)) ([e4a4758](supabase@e4a4758)) * upgrade otel to v1.26 ([supabase#1585](supabase#1585)) ([cdd13ad](supabase@cdd13ad)) * use largest avatar from spotify instead ([supabase#1210](supabase#1210)) ([4f9994b](supabase@4f9994b)), closes [supabase#1209](supabase#1209) ### Bug Fixes * define search path in auth functions ([supabase#1616](supabase#1616)) ([357bda2](supabase@357bda2)) * enable rls & update grants for auth tables ([supabase#1617](supabase#1617)) ([28967aa](supabase@28967aa)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please). Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>

J0 added 3 commits May 21, 2024 18:00

feat: upgrade otel

b82ab8c

fix: format

f265e59

fix: remove user-agent checks

e38ac79

J0 added 3 commits May 23, 2024 18:59

fix: reinstate metrics

60df2a4

fix: remove comments

b1d213e

fix: remove semconv http user agent keys

7d2b27b

J0 changed the title ~~feat: upgrade otel~~ feat: upgrade otel to v1.26 May 23, 2024

J0 commented May 23, 2024

View reviewed changes

internal/api/opentelemetry-tracer_test.go Show resolved Hide resolved

internal/models/cleanup.go Show resolved Hide resolved

internal/models/cleanup.go Show resolved Hide resolved

J0 commented May 23, 2024

View reviewed changes

internal/observability/metrics.go Show resolved Hide resolved

J0 commented May 23, 2024

View reviewed changes

internal/observability/metrics.go Show resolved Hide resolved

fix: remove TODO

920be6f

J0 marked this pull request as ready for review May 23, 2024 18:53

J0 requested a review from a team as a code owner May 23, 2024 18:53

kangmingtay reviewed May 29, 2024

View reviewed changes

hf approved these changes May 30, 2024

View reviewed changes

J0 added 2 commits June 3, 2024 12:38

fix: use atomic .Add() and move logrus.Info( outside of switch

6edee9b

fix: convert WithAttributes to WithAttributeSet

2b7d015

Merge branch 'master' into j0/upgrade_otel_deps

1c2291b

J0 added 2 commits June 7, 2024 12:47

fix: add go.mod

6aad83b

fix: reinstate metric.withAttributes

5ff7939

J0 merged commit cdd13ad into master Jun 7, 2024
2 checks passed

J0 deleted the j0/upgrade_otel_deps branch June 7, 2024 11:54

github-actions bot mentioned this pull request Jun 7, 2024

chore(master): release 2.154.0 #1610

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

feat: upgrade otel to v1.26 #1585

feat: upgrade otel to v1.26 #1585

J0 commented May 21, 2024 •

edited

Loading

coveralls commented May 22, 2024 •

edited

Loading

hf left a comment

kangmingtay commented Jun 4, 2024

J0 commented Jun 6, 2024

J0 commented Jun 6, 2024

feat: upgrade otel to v1.26 #1585

feat: upgrade otel to v1.26 #1585

Conversation

J0 commented May 21, 2024 • edited Loading

What kind of change does this PR introduce?

How this was tested

coveralls commented May 22, 2024 • edited Loading

Pull Request Test Coverage Report for Build 9416496963

Details

💛 - Coveralls

hf left a comment

Choose a reason for hiding this comment

kangmingtay commented Jun 4, 2024

J0 commented Jun 6, 2024

J0 commented Jun 6, 2024

J0 commented May 21, 2024 •

edited

Loading

coveralls commented May 22, 2024 •

edited

Loading