Use largest avatar returned by Spotify

[william-matz]

Bug report

• I confirm this is a bug with Supabase, not with my own application.
• I confirm I have searched the Docs, GitHub Discussions, and Discord.

Describe the bug

I noticed 1-2 weeks ago that the profile images for new users with Spotify Auth are small (64x64), whereas they used to be (300x300). After further investigation, it looks like Spotify's array of images no longer sorts images in reverse size order, so images[0].url is the smaller image now. This looks bad in most avatar implementations.

Expected behavior

The avatars should be sorted by size (Width or Height) and we should return the Url of the largest one.

Additional context

Spotify docs here: https://developer.spotify.com/documentation/web-api/reference/get-current-users-profile

Where to fix: https://github.com/supabase/gotrue/blob/5caacc1f81ff20f8f09f4598b510c767e589a1c5/internal/api/provider/spotify.go#L83C1-L85C3

This seems like a simple fix but I've never written go before. I may attempt it!

[william-matz]

ChatGPT is guiding me towards something like this:

var avatarURL string

if len(u.Avatars) >= 1 {
	largestAvatar := u.Avatars[0]
	
	for _, avatar := range u.Avatars {
		if avatar.Height * avatar.Width > largestAvatar.Height * largestAvatar.Width {
			largestAvatar = avatar
		}
	}
	
	avatarURL = largestAvatar.Url
}