fix: revert changes to auth functions

[J0]

What kind of change does this PR introduce?

The changes in Auth v2.154.1 are not compatible with the current version of Postgrest and associated features on dashboard, including PostgREST

This is because of changes which affect auth.* functions (e.g. auth.uid()). Ostensibly, newer versions of PostgREST set store claims under request.jwt.claims rather than request.jwt.claim.sub which might have lead to auth.uid() etc returning null instead of the user ID as expected.

We revert the change by reinstating the older version of the functions. We preserve search_path='' though.

For more context see: https://supabase.slack.com/archives/C07A55TKL3S/p1719237535404369

Functions taken from:
auth.jwt() -

auth/migrations/20220531120530_add_auth_jwt_function.up.sql

Line 4 in e81c25d

comment on function {{ index .Options "Namespace" }}.role() is 'Deprecated. Use auth.jwt() -> ''role'' instead.';

auth.uid()-

auth/migrations/20220224000811_update_auth_functions.up.sql

Line 25 in e81c25d

create or replace function {{ index .Options "Namespace" }}.email()

auth.email() -

auth/migrations/20220224000811_update_auth_functions.up.sql

Line 25 in e81c25d

create or replace function {{ index .Options "Namespace" }}.email()

Tested by running:

SELECT
    n.nspname as schema_name,
    p.proname as function_name,
    pg_catalog.pg_get_functiondef(p.oid) as function_definition
FROM
    pg_catalog.pg_proc p
    LEFT JOIN pg_catalog.pg_namespace n ON n.oid = p.pronamespace
WHERE
    n.nspname = 'auth'
ORDER BY
    schema_name,
    function_name;

Against the v2.152.0 and doing a diff. Also tested against a staging instance after substituting the placeholder and creating the new functions.

[coveralls]

Pull Request Test Coverage Report for Build 9647790488

Details

• 0 of 0 changed or added relevant lines in 0 files are covered.
• No unchanged relevant lines lost coverage.
• Overall coverage remained the same at 57.674%

---

Totals
Change from base Build 9596939146:	0.0%
Covered Lines:	8699
Relevant Lines:	15083

---

💛 - Coveralls

[coveralls]

Pull Request Test Coverage Report for Build 9647826417

Details

• 0 of 0 changed or added relevant lines in 0 files are covered.
• No unchanged relevant lines lost coverage.
• Overall coverage remained the same at 57.674%

---

Totals
Change from base Build 9596939146:	0.0%
Covered Lines:	8699
Relevant Lines:	15083

---

💛 - Coveralls

[coveralls]

Pull Request Test Coverage Report for Build 9647965343

Details

• 0 of 0 changed or added relevant lines in 0 files are covered.
• No unchanged relevant lines lost coverage.
• Overall coverage remained the same at 57.674%

---

Totals
Change from base Build 9596939146:	0.0%
Covered Lines:	8699
Relevant Lines:	15083

---

💛 - Coveralls

[hf]

Hmm is it like this?

[J0]

Are you referring to the lack of search_path ? Set that to '' the rest should be accurate

[J0]

Not actually sure that we need to replace .jwt() at all let me check.

[hf]

Sorry just wanted to validate this...

auth/migrations/20220531120530_add_auth_jwt_function.up.sql

Line 7 in e81c25d

create or replace function {{ index .Options "Namespace" }}.jwt()

[hf]

Ugh... what about we just drop this whole search path shenaningans...

I'm worried that replacing a function may drop some grants we can't track.

[J0]

As discussed, closing in favour of a revert.

[coveralls]

Pull Request Test Coverage Report for Build 9648187697

Details

• 0 of 0 changed or added relevant lines in 0 files are covered.
• No unchanged relevant lines lost coverage.
• Overall coverage remained the same at 57.674%

---

Totals
Change from base Build 9596939146:	0.0%
Covered Lines:	8699
Relevant Lines:	15083

---

💛 - Coveralls