merge from origin #1
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
azurerm_key_vault_certificate return thumbprint as hex
new action added Microsoft.SqlVirtualMachine/* So the actions changed from 37 to 38. Fix this test issue directly.
VM Contributor build-in permissions actions count increase.
Add .go-version genereated by `goenv` tool into ignore list.
It looks like the documentation for `start_ip_address` was errantly copied from a different field. Update it with the correct documentation.
* New Resource: `azurerm_mysql_virtual_network_rule` Fixes #1340 * Updated test SKU * Added mysqlVirtualNetworkRulesClient back into config * Documenting the MySQL/PostgreSQL rules need the GeneralPurpose/MemoryOptimized tiers
* added support for StorageAccountTypesStandardSSDLRS * delete failed test block * Documenting the new `StandardSSD_LRS` type * Adding tests for VM/VMSS for the new StandardSSD_LRS type
…1899) * AzureStack: backport virtual network gateway connection PR comments * fixed bad package reference and minor typo * removed virtual network gateway connection import test file
ServiceBus Namespace: polling for the deletion
Missing double quote in the example default_backend_http_settings_name assignment.
* Add timespan test cases according to issue #646 * Correct the TimeSpan documentation in sb_queue and sb_topic * Add timespan validation function in sb
Update resource_arm_logic_app_trigger_http_request.go
Log Analytics Solution: removing crash points/refactoring
…llection` (#1627) * add firewall resource skeleton * basic test * create method * complete firewall resource * begin network rule resource * add firewall import * fix firewall tests * tweak firewall tests * complete network rule collection * start docs * nil checks * update nil checks * update find rule collection * formatting updates * docs * rename files * rename arm_azure_firewall to arm_firewall * formatting * rename doc * rename nrc doc * WaitForCompletionRef * Refactoring of Azure Firewall: - Locking on the Firewall Name - Handling resources being deleted outside of Terraform - Removing some crash points - Making the Protocol and Action type case-sensitive - Refactoring the virtual resource to allow for - Parsing the ID rather than using the config for the delete and read functions (so delete's are successful when the config's gone) - Rewriting some of the tests for the Network Rule Collections, to check the resource's state rather than the object - Updating the documentation (and including Import support for Network Rule Collections) * Deleting the separate test file * Adding validation to fields ``` $ acctests azurerm TestValidateFirewallName === RUN TestValidateFirewallName --- PASS: TestValidateFirewallName (0.00s) PASS ok github.com/terraform-providers/terraform-provider-azurerm/azurerm 0.344s ``` * Renaming the fix ip method * Fixing issues highlighted in code review * Fixing the test check function to load the firewall, rather than the collection * Fixing a bad refactor * Fixing a broken test * Docs: adding a sidebar link
…eout azurestack_public_ip: correct import & read idle_timeout_in_minutes
steve-hawkins
pushed a commit
that referenced
this pull request
Nov 15, 2018
Add test and documentation
steve-hawkins
pushed a commit
that referenced
this pull request
Jan 3, 2019
add _id to fields for clarity
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
updates