-
Notifications
You must be signed in to change notification settings - Fork 4.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
azurestack_public_ip: correct import & read idle_timeout_in_minutes #1925
Conversation
a702032
to
98699ef
Compare
tests pass:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Otherwise lgtm
azurerm/resource_arm_public_ip.go
Outdated
@@ -236,6 +234,10 @@ func resourceArmPublicIpRead(d *schema.ResourceData, meta interface{}) error { | |||
} else { | |||
d.Set("ip_address", "") | |||
} | |||
|
|||
if idleTimeout := props.IdleTimeoutInMinutes; idleTimeout != nil { | |||
d.Set("idle_timeout_in_minutes", idleTimeout) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
d.Set will handle this value being nil - so we should be able to omit the if statement here?
I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. If you feel I made an error 🤖 🙉 , please reach out to my human friends 👉 [email protected]. Thanks! |
Discovered in AzureStack