Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

azurestack_public_ip: correct import & read idle_timeout_in_minutes #1925

Merged
merged 2 commits into from
Sep 14, 2018

Conversation

katbyte
Copy link
Collaborator

@katbyte katbyte commented Sep 14, 2018

@katbyte katbyte added this to the 1.16.0 milestone Sep 14, 2018
@ghost ghost added the size/L label Sep 14, 2018
@ghost ghost added the size/L label Sep 14, 2018
@katbyte
Copy link
Collaborator Author

katbyte commented Sep 14, 2018

tests pass:

[20:10:43] kt@snowbook:~/hashi/..3../terraform-providers/terraform-provider-azurerm$ make fmt; make testacc TEST=./azurerm TESTARGS=-test.run=TestAccAzureRMPublicIpStatic
gofmt -w $(find . -name '*.go' |grep -v vendor)
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./azurerm -v -test.run=TestAccAzureRMPublicIpStatic -timeout 180m
=== RUN   TestAccAzureRMPublicIpStatic_basic
--- PASS: TestAccAzureRMPublicIpStatic_basic (95.68s)
=== RUN   TestAccAzureRMPublicIpStatic_basic_withDNSLabel
--- PASS: TestAccAzureRMPublicIpStatic_basic_withDNSLabel (107.22s)
=== RUN   TestAccAzureRMPublicIpStatic_standard
--- PASS: TestAccAzureRMPublicIpStatic_standard (75.68s)
=== RUN   TestAccAzureRMPublicIpStatic_disappears
--- PASS: TestAccAzureRMPublicIpStatic_disappears (87.54s)
=== RUN   TestAccAzureRMPublicIpStatic_idleTimeout
--- PASS: TestAccAzureRMPublicIpStatic_idleTimeout (95.37s)
=== RUN   TestAccAzureRMPublicIpStatic_withTags
--- PASS: TestAccAzureRMPublicIpStatic_withTags (103.42s)
=== RUN   TestAccAzureRMPublicIpStatic_update
--- PASS: TestAccAzureRMPublicIpStatic_update (120.81s)
=== RUN   TestAccAzureRMPublicIpStatic_importIdError
--- PASS: TestAccAzureRMPublicIpStatic_importIdError (92.60s)
PASS
ok  	github.com/terraform-providers/terraform-provider-azurerm/azurerm	778.363s
[20:24:01] kt@snowbook:~/hashi/..3../terraform-providers/terraform-provider-azurerm$

Copy link
Contributor

@tombuildsstuff tombuildsstuff left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Otherwise lgtm

@@ -236,6 +234,10 @@ func resourceArmPublicIpRead(d *schema.ResourceData, meta interface{}) error {
} else {
d.Set("ip_address", "")
}

if idleTimeout := props.IdleTimeoutInMinutes; idleTimeout != nil {
d.Set("idle_timeout_in_minutes", idleTimeout)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

d.Set will handle this value being nil - so we should be able to omit the if statement here?

@katbyte katbyte merged commit dd19d9e into master Sep 14, 2018
@katbyte katbyte deleted the b-publicip-idle_timeout branch September 14, 2018 15:48
katbyte added a commit that referenced this pull request Sep 14, 2018
@ghost
Copy link

ghost commented Mar 6, 2019

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. If you feel I made an error 🤖 🙉 , please reach out to my human friends 👉 [email protected]. Thanks!

@ghost ghost locked and limited conversation to collaborators Mar 6, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants