Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update TimeSpan documentation in Service Bus Queue/Topic #1921

Merged
merged 3 commits into from
Sep 13, 2018

Conversation

JunyiYi
Copy link

@JunyiYi JunyiYi commented Sep 13, 2018

The original documentation regarding auto_delete_on_idle, default_message_ttl and duplicate_detection_history_time_window is not correct any more. Azure REST APIs have replaced all C# TimeSpan format with the new ISO8601 duration format. This change is also caught in #646 .

In this PR:

  • Update the documentation to use the latest ISO8601 duration format
  • Add test cases in order to catch such problems as soon as possible in the future
  • Add ValidateFunc so user could see the error before applying

@ghost ghost added the size/L label Sep 13, 2018
@JunyiYi JunyiYi self-assigned this Sep 13, 2018
@JunyiYi JunyiYi added this to the Soon milestone Sep 13, 2018
@tombuildsstuff tombuildsstuff removed this from the Soon milestone Sep 13, 2018
Copy link
Contributor

@tombuildsstuff tombuildsstuff left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@tombuildsstuff tombuildsstuff added this to the 1.15.0 milestone Sep 13, 2018
@tombuildsstuff
Copy link
Contributor

Tests pass:

screenshot 2018-09-13 at 16 48 39

@ghost
Copy link

ghost commented Mar 6, 2019

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. If you feel I made an error 🤖 🙉 , please reach out to my human friends 👉 [email protected]. Thanks!

@ghost ghost locked and limited conversation to collaborators Mar 6, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants