New Resource: azurerm_mysql_virtual_network_rule
#1879
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This comment has been minimized.
This comment has been minimized.
tombuildsstuff
force-pushed
the
mysql-virtual-network-rule
branch
from
ed805e5 to
d355f2a
Compare
This comment has been minimized.
This comment has been minimized.
tombuildsstuff
changed the title
azurerm_mysql_virtual_network_ruleazurerm_mysql_virtual_network_rule
|
Pulled the PostgreSQL refactor out into #1882 |
WodansSon
approved these changes
Sep 7, 2018
There was a problem hiding this comment.
@tombuildsstuff LGTM I left a question in the review for your consideration.
tombuildsstuff
force-pushed
the
mysql-virtual-network-rule
branch
from
d355f2a to
d95659f
Compare
|
@tombuildsstuff I updated the test SKU's to fix the test cases, hope you don't mind. |
|
@tombuildsstuff I also resolved the conflict with master, hope that's ok. |
|
|
tombuildsstuff
changed the title
azurerm_mysql_virtual_network_ruleazurerm_mysql_virtual_network_rule
|
Tests still pass:
|
|
I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. If you feel I made an error 🤖 🙉 , please reach out to my human friends 👉 [email protected]. Thanks! |
ghost
locked and limited conversation to collaborators
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is so similar to the PostgreSQL Virtual Network Rule I've refactored that too so we have a common validation function
Fixes #1340