only show lint messages of the current linting file #304
Conversation
Test Plan: Opened a file, linted, and checked console for errors.
Delete some unused imports
Only widen the gutter when showGutter is enabled
new linter [linter-jsxhint](https://atom.io/packages/linter-jsxhint), for JSX (React.js), using `jsxhint`
Should fix steelbrain#157. Test Plan: Crossed fingers.
Conflicts: lib/linter.coffee
Tested this with csslint, pylint, coffeelint on OS X and everything seemed to work. Since this apparently fixes issues for Windows users, I'm merging it in.
These classes get put on the containing `atom-panel` element with the new panel API.
Remove panel classes
With lint on change disabled, timing out linters doesn't make as much sense. I implemented this so I could test out how the linter feels with no timeout. Fixes steelbrain#204. Test Plan: Open a complex Python file for which pylint used to time out. Notice errors appear after a long time.
| computeRange: (match) -> | ||
| if match.file? | ||
| if match.file isnt @lintingFile | ||
| # TODO: show a message to indicate there are errors in other files |
There was a problem hiding this comment.
did you mean show something in treeView?
There was a problem hiding this comment.
@hd-deman Perhaps. I know little about Linter itself. Maybe it could be improved in other PR later?
|
Any news here? This is a big hurdle to using atom with rust. |
|
@hd-deman Can you take care of this one? |
|
Any news on the merge situation? |
|
bumpity bump |
|
bumping intensifies |
|
Woo! |
|
To be clear this wasn't merged. I believe this can be solved in |
|
To be clear, I'd like to say, I didn't submit soooooooo many commits. I don't known what happens here. @AsaAyers I'll try new Linter api if possible. Thank you! |
I'm working on Rust Linter, which would like to support Rust's package manager, Cargo. Cargo was designed to build a package (or project), which is a group of many source files. While linting a file inside a package, we build the full package (use Cargo). (You can't just compile only one of these files individually.) There are maybe some errors, cause by files other than the current linting one, which need to be ignored. This PR changes the behavior to only show lint messages of the current linting file.
This is a backward compatible improvement.