Only widen the gutter when showGutter is enabled #137
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
After installing linter the gutter becomes wider. Even when the config option showGutter is disabled the gutter is still wider than it should be. This change only adds gutter CSS when showGutter is enabled. Test Plan: Toggled showGutter on and off and saw gutter change width
|
Any chance of having this merged @hd-deman? It fixes an issue where simply having linter installed with gutters turned off causes gutters to be wider than they should be. After this change the gutter only become wide if gutter icons are enabled in linter (as you can see if the gif). |
Conflicts: lib/gutter-view.coffee lib/linter-view.coffee stylesheets/linter.less
|
@hd-deman I fixed the merge conflicts. It's pretty much a rewrite, so please take another look. |
|
👍 good |
hd-deman
added a commit
that referenced
this pull request
Aug 5, 2014
Only widen the gutter when showGutter is enabled
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
After installing linter the gutter becomes wider. Even when the config option
showGutters is disabled the gutter is still wider than it should be. This change
only adds gutter CSS when showGutters is enabled.