Use decorations API #147
Merged
Use decorations API #147
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This new API is designed exactly for our use case. One benefit is that `GutterView.render` is now no longer called hundreds of times a second (!) I copied most of the implementation from the git-diff package. Test plan: Opened a new editor and verified that gutter markers appear and disappear when lint errors are caused and resolved. Also added a logging statement to `GutterView.render` to verify that it's now only called when the file is linted.
dmnd
changed the title
Again the implementation is inspired by the git-diff package. Test Plan: Opened a new editor and verified that highlights show up. I had to tweak the indexing for columns after noticing that errors on the final line didn't show up after this change.
Since `GutterView` and `HighlightsView` were basically the same thing, I extracted out the shared code to `LinterView` and deleted them. Test Plan: Opened a file with lint errors. In another Atom window, went to settings and turned gutter and highlights on and off and made sure that these settings still updated in the other window.
| # errors on line 1 | ||
| if (rowStart == -1) | ||
| rowStart = rowEnd = 0 | ||
| decrementParse = (x) -> |
There was a problem hiding this comment.
In a lot of places we need to decrement a base-1 index into a base-0 index. This function does that, as well as parses as an integer and makes sure we don't end up with -1.
|
I'm finished with this now, can someone review and consider merging? |
Conflicts: lib/linter-view.coffee
|
FYI this conflicts with #137. If you pull one of them I can fix up the other one. |
|
ok. please fix #137 |
This was referenced Aug 4, 2014
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I'm converting the gutter and highlights view to use the new decorations API.
This is good because it lets us delete a lot of functionality that's now provided by core Atom.