Filter messages to only display those related to the current file #552
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Test Plan: Looked at a lint message. Edited the message in the inspector to make it really long, to see what happened for linebreaking. It wraps eventually so this seems good enough.
In `deactivate`, `remove` is called, but before this change, `remove` doesn't exist. The real fix for this is probably to make `InlineView` a real `View`, but for now this will stop errors. The fact that Atom crashes is a separate issue that I'll make a report for. Test Plan: Press `ctrl-cmd-opt l` and Atom doesn't crash
Fixes steelbrain#212. Test Plan: Linted a file and saw no errors
When there are no cursors, this throws. Though in that case it looks like both these views can just return early since they have nothing to render. Test Plan: Crossed fingers
Test Plan: Ran specs, they all pass
Fix positioning when inline view is on last line
Attempting to prevent the following exception:
Uncaught Error: No screen line exists when converting buffer row to screen row /Applications/Atom.app/Contents/Resources/app/src/display-buffer.js:932
module.exports.DisplayBuffer.screenPositionForBufferPosition /Applications/Atom.app/Contents/Resources/app/src/display-buffer.js:932
module.exports.Marker.getHeadScreenPosition /Applications/Atom.app/Contents/Resources/app/src/marker.js:211
Marker /Applications/Atom.app/Contents/Resources/app/src/marker.js:45
module.exports.DisplayBuffer.getMarker /Applications/Atom.app/Contents/Resources/app/src/display-buffer.js:1124
module.exports.DisplayBuffer.markBufferRange /Applications/Atom.app/Contents/Resources/app/src/display-buffer.js:1156
module.exports.Editor.markBufferRange /Applications/Atom.app/Contents/Resources/app/src/editor.js:1186
LinterView.display linter-view.coffee:180
LinterView.processMessage linter-view.coffee:159
(anonymous function) linter-view.coffee:1
(anonymous function) linter-view.coffee:142
Linter.processMessage linter.coffee:150
(anonymous function) linter.coffee:127
BufferedProcess.triggerExitCallback /Applications/Atom.app/Contents/Resources/app/src/buffered-process.js:52
(anonymous function) /Applications/Atom.app/Contents/Resources/app/src/buffered-process.js:59
(anonymous function) /Applications/Atom.app/Contents/Resources/app/src/buffered-process.js:105
EventEmitter.emit events.js:129
(anonymous function) net.js:461
Test Plan:
Can't repro that issue, but did test that error messages still work.
Fixes steelbrain#218. Test Plan: Opened a java file and didn't get ENOTEMPTY errors.
Added a check to return early for the common case where messages haven't changed, and the cursor is on the same line. Test Plan: Moved a cursor around on the same line and it feels a bit faster.
Add LESS to list of available linters
Fix issue links in changelog
Revert "Fix issue links"
Fixes steelbrain#165. Test plan: * Opened a file * Caused a lint error on the final line * Deleted a line from the middle of the file * No error
🐛 Fix wavy underline with non-standard line height steelbrain#427
feat(lintChangeMethod): add options
Use undeprecated getActiveTextEditor
add `linter-js-standard`
child's configuration observe/dispose
…ptions Iterate over base options
In certain systems, for instance the package manager cargo for the rust language, an entire package with multiple files must be built at once and all the errors are reported in bulk. Previously, it was impossible to filter these messages based on the file they apply to and only show the ones relevant to the current file. This commit provides the hooks for linters to say which file a message belongs to (though this is optional, to maintain backwards compatibility) so that we can filter out all messages not related to the current file. By default, all messages are assumed to be relevant to the current file.
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In certain systems, for instance the package manager cargo for
the rust language, an entire package with multiple files must
be built at once and all the errors are reported in bulk.
Previously, it was impossible to filter these messages based on the
file they apply to and only show the ones relevant to the current file.
This commit provides the hooks for linters to say which file a message
belongs to (though this is optional, to maintain backwards compatibility)
so that we can filter out all messages not related to the current file.
By default, all messages are assumed to be relevant to the current file.
This PR is an updated version of #304, which has partially bitrotted/accrued
merge conflicts, and is largely a prerequisite to productively using rust
with atom.