Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add serialVersionUID to DefaultSavedRequest and SavedCookie #10676

Closed
wants to merge 117 commits into from
Closed

Add serialVersionUID to DefaultSavedRequest and SavedCookie #10676

wants to merge 117 commits into from

Conversation

jakspok
Copy link
Contributor

@jakspok jakspok commented Jan 4, 2022 •
edited
Loading

Add serialVersionUID to DefaultSavedRequest and SavedCookie
#10594

Jay Bryant and others added 30 commits June 4, 2021 14:13
Editing pass
9219cbf 
I went through everything to get it to fit with Spring's docuemntation standard.
Lots of small changes for punctuation, grammar, usage, voice, and so on.
Also added some links, mostly to the API Javadoc.
Further changes
0fdee9c 
A file changed while I was working on it, as the developers
added more material for Kotlin. I edited the changes, to make
everything be consistent.
Change to main
849aaa4 
The switch to main triggered some conflicts, which I have fixed in this commit.
Various fixes
a6d0719 
Fixes to make the build work.
Accounted for feedback
93893de 
Incorporated suggested changes from a review.
Further changes based on feedback
7171521 
Mostly restoring the formatting of admonitions.
Add missing delimiters
252ef78 
I missed three block delimiters while restoring admonition formatting.
@marcusdacoregio
Update to Spring Security 6.0
12f3e90
@marcusdacoregio
Temporarily downgrade Java compat level for AspectJ classes
514558d 
AspectJ doesn't support JDK17 language level (yet).
For the time being, this commit is downgrading the language level for
the aspectJ generated classes to 1.8.

Issue spring-projectsgh-10349
@marcusdacoregio
Remove BlockHound dependency
5609626 
The dependency is not needed anymore and there is a issue when using OpenJDK 13 or higher reactor/BlockHound#33

Issue spring-projectsgh-10343
@marcusdacoregio
Upgrade to JDK 17
010f719 
Closes spring-projectsgh-10343
@marcusdacoregio
Switch workflows to use a JDK17 baseline
e5ff139 
Closes spring-projectsgh-10353
@marcusdacoregio
Point to Samples on 6.0.x branch
f672754
@marcusdacoregio
Remove remoting technologies support
b2e6c60 
Closes spring-projectsgh-10366
@marcusdacoregio
Upgrade to AspectJ 1.9.8-RC1
4f0cc13 
Issue spring-projectsgh-10349
@marcusdacoregio
Update to Spring Framework 6.0
db60df2 
Issue spring-projectsgh-10360
@marcusdacoregio
Fix CAS Client Java lib not working with Jakarta EE 9
5c4dd51 
Copy the code from the library and change it to support the Jakarta classes

Issue spring-projectsgh-10360
@marcusdacoregio
Drop EhCache2 support
5a0f1d5 
Issue spring-projectsgh-10363
@marcusdacoregio
Update Structure101 version
34e77cb
@marcusdacoregio
Revert "Fix CAS Client Java lib not working with Jakarta EE 9"
17e0a47 
This reverts commit aa5564e.
@marcusdacoregio
Remove CAS module
caf4c47 
Closes spring-projectsgh-10441
@rwinch
Use explicit version from antora.yml
e2c5772
@rwinch
Put nav in generated docs
e4a465a
@rwinch
Quote the version for antora.yml
c705a09
@jzheaux
Separate Namespace Servlet Docs
869e379 
Issue spring-projectsgh-10367
@sjohnr
Document authentication helper method in WebClient integration
49f3c0c 
Closes spring-projectsgh-10120
@sjohnr
Document parameters converter in oauth2 client servlet docs
b27c7e1 
Closes spring-projectsgh-10467
@jzheaux
Separate OAuth 2.0 Client Servlet Docs
8c508d6 
Issue spring-projectsgh-10367
@jzheaux
Separate OAuth 2.0 Login Servlet Docs
3db13de 
Issue spring-projectsgh-10367
@jzheaux
Separate OAuth 2.0 Client Reactive Docs
5019653 
Issue spring-projectsgh-10367
OrangeDog and others added 15 commits December 9, 2021 12:16
@OrangeDog @jzheaux
Clarify behaviour of enableSessionUrlRewriting
c1b0e59 
See spring-projects#3087
@jzheaux
Polish enableSessionUrlRewriting Clarification
81a9302 
Closes spring-projectsgh-7644
@marcusdacoregio
Introduce AuthorizationManagerWebInvocationPrivilegeEvaluator
eda3468 
Closes spring-projectsgh-10590
@marcusdacoregio
Add RequestMatcherEntry
51b4bd6
@marcusdacoregio
Configure WebInvocationPrivilegeEvaluator bean for multiple filter ch…
d884d9a 
…ains

Closes spring-projectsgh-10554
@rwinch
Merge Clean up Reference Documentation
2fb056b 
Closes spring-projectsgh-9668
@rwinch
Fix xsd tests
2471e32
@jzheaux
Remove commons-logging from saml2
cbf0e1d 
Issue spring-projectsgh-10499
@sjohnr
Add GitHubReleasePlugin with createGitHubRelease task
80e39e9 
Closes spring-projectsgh-10456
Closes spring-projectsgh-10457
@sjohnr
Fix inconsistency in hasProperty check
ad90745
@marcusdacoregio
Upgrade to Spring Framework 6.0.0-M1
d41ec2b
@marcusdacoregio
Upgrade to AspectJ 1.9.8.RC3
d79543b 
Issue spring-projectsgh-10349
@jzheaux
Support No SingleLogoutServiceLocation
cb008fa 
Closes spring-projectsgh-10674
@jzheaux
Remove SAML 2.0 Logout Default
45b7fed 
Closes spring-projectsgh-10607
@jakspok
add serialVersionUID
3d37b19
@spring-projects-issues spring-projects-issues added the status: waiting-for-triage An issue we've not yet triaged label Jan 4, 2022
@marcusdacoregio
Copy link
Contributor

Hi @jakspok. Nice work.

Can you please change the target branch from main to 5.7.x? Also, it would be nice if you could change the commit message to something like this:

Add serialVersionUID to DefaultSavedRequest and SavedCookie

Closes gh-10594

@marcusdacoregio marcusdacoregio added this to the 5.7.x milestone Jan 12, 2022
@jakspok jakspok changed the title add serialVersionUID Add serialVersionUID to DefaultSavedRequest and SavedCookie Jan 12, 2022
@jakspok jakspok changed the base branch from main to 5.7.x January 12, 2022 14:10
@eleftherias eleftherias added in: web An issue in web modules (web, webmvc) and removed status: waiting-for-triage An issue we've not yet triaged labels Jan 13, 2022
@marcusdacoregio marcusdacoregio self-assigned this Jan 18, 2022
@marcusdacoregio marcusdacoregio added type: enhancement A general enhancement status: duplicate A duplicate of another issue labels Jan 18, 2022
@marcusdacoregio marcusdacoregio modified the milestones: 5.7.x, 5.7.0-M2 Jan 18, 2022
@marcusdacoregio
Copy link
Contributor

I decided to take the commit, apply a polish and push it to 5.7.x due to this PR having so many conflicts (probably you did not rebase your branch). Note that you are still the author of the changes.

Closed via 7435da6

@jakspok jakspok deleted the add-serialuuid-to-DefaultSavedRequest-SavedCookie branch January 18, 2022 15:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@marcusdacoregio marcusdacoregio

Labels
in: web An issue in web modules (web, webmvc) status: duplicate A duplicate of another issue type: enhancement A general enhancement
Projects
None yet
Milestone
5.7.0-M2
Development

Successfully merging this pull request may close these issues.