Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Document parameters converter in oauth2 client servlet docs #10467

Closed
sjohnr opened this issue Nov 3, 2021 · 1 comment · Fixed by #10469
Closed

Document parameters converter in oauth2 client servlet docs #10467

sjohnr opened this issue Nov 3, 2021 · 1 comment · Fixed by #10469
Assignees
@sjohnr
Labels
in: docs An issue in Documentation or samples type: enhancement A general enhancement
Milestone
5.6.1

Comments

@sjohnr
Copy link
Member

sjohnr commented Nov 3, 2021 •
edited
Loading

Servlet documentation should mention how to provide a custom parameters converter to override parameters of an OAuth 2.0 Access Token Request:

  • AbstractOAuth2AuthorizationGrantRequestEntityConverter.setParametersConverter().
  • AbstractOAuth2AuthorizationGrantRequestEntityConverter.addParametersConverter().

Currently, only reactive documentation mentions this capability (in AbstractWebClientReactiveOAuth2AccessTokenResponseClient).
@sjohnr sjohnr added in: docs An issue in Documentation or samples type: enhancement A general enhancement labels Nov 3, 2021
@sjohnr sjohnr added this to the 5.6.x milestone Nov 3, 2021
@sjohnr sjohnr self-assigned this Nov 3, 2021
@sjohnr sjohnr changed the title Document how to add parameters in oauth2 client servlet docs Document parameters converter in oauth2 client servlet docs Nov 3, 2021
sjohnr added a commit to sjohnr/spring-security that referenced this issue Nov 3, 2021
@sjohnr
Document parameters converter in oauth2 client servlet docs
f36040d 
Closes spring-projectsgh-10467
@sjohnr sjohnr modified the milestones: 5.6.x, 5.6.0 Nov 3, 2021
@sjohnr sjohnr mentioned this issue Nov 3, 2021
Merged
sjohnr added a commit that referenced this issue Nov 3, 2021
@sjohnr
Document parameters converter in oauth2 client servlet docs
b27c7e1 
Closes gh-10467
@sjohnr sjohnr modified the milestones: 5.6.0, 6.x Nov 4, 2021
@jzheaux jzheaux modified the milestones: 6.x, 6.0.0-M1 Nov 5, 2021
jzheaux pushed a commit that referenced this issue Nov 5, 2021
@sjohnr @jzheaux
Document parameters converter in oauth2 client servlet docs
e350c8a 
Closes gh-10467
@sjohnr sjohnr modified the milestones: 6.0.0-M1, 5.6.1 Dec 1, 2021
@sjohnr
Copy link
Member Author

sjohnr commented Dec 1, 2021

Moved to 5.6.1 milestone, as this missed the 5.6.0 release notes.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@sjohnr sjohnr

Labels
in: docs An issue in Documentation or samples type: enhancement A general enhancement
Projects
None yet
Milestone
5.6.1
Development

Successfully merging a pull request may close this issue.

Document parameters converter in oauth2 client servlet docs sjohnr/spring-security
2 participants
@jzheaux @sjohnr