-
Notifications
You must be signed in to change notification settings - Fork 5.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
commons-logging:commons-logging is a transitive dependency of some modules #10499
Labels
in: build
An issue in the build
status: backported
An issue that has been backported to maintenance branches
type: bug
A general bug
Milestone
Comments
wilkinsona
added
status: waiting-for-triage
An issue we've not yet triaged
type: bug
A general bug
labels
Nov 12, 2021
I'm taking a look at |
jzheaux
added a commit
that referenced
this issue
Dec 16, 2021
rwinch
added a commit
that referenced
this issue
Jan 19, 2022
rwinch
added a commit
that referenced
this issue
Jan 19, 2022
rwinch
added a commit
that referenced
this issue
Jan 19, 2022
rwinch
added a commit
that referenced
this issue
Jan 19, 2022
rwinch
added a commit
that referenced
this issue
Jan 19, 2022
rwinch
added a commit
that referenced
this issue
Jan 19, 2022
rwinch
added a commit
that referenced
this issue
Jan 19, 2022
rwinch
added a commit
that referenced
this issue
Jan 19, 2022
Issue gh-10499 # Conflicts: # dependencies/spring-security-dependencies.gradle
This was referenced Jan 19, 2022
rwinch
added
in: build
An issue in the build
status: backported
An issue that has been backported to maintenance branches
labels
Jan 19, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
in: build
An issue in the build
status: backported
An issue that has been backported to maintenance branches
type: bug
A general bug
Describe the bug
Spring projects should use Spring Framework's
spring-jcl
module in place ofcommons-logging:commons-logging
, however some Spring Security modules pull incommons-logging:commons-logging
as a transitive dependency.spring-security-openid
in 5.5.x is one example.spring-security-saml2-service-provider
in 5.4.x is another.To Reproduce
Looking at build scans on ge.spring.io is one way to observe the problem for 5.5.x at least (I couldn't find any scans tagged with
5.4.x
). You can also seecommons-logging:commons-logging
leaking into Spring Boot's build via Spring Security (and many other dependencies) in Boot's build scans such as this one.Expected behavior
commons-logging
is not a direct or transitive dependency of any Spring Security module.Sample
N/A.
The text was updated successfully, but these errors were encountered: