Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove CAS module #10441

Closed
marcusdacoregio opened this issue Oct 25, 2021 · 6 comments
Closed

Remove CAS module #10441

marcusdacoregio opened this issue Oct 25, 2021 · 6 comments
Assignees
Labels
type: task A general task
Milestone

Comments

@marcusdacoregio
Copy link
Contributor

We should remove the CAS module entirely since we depend on the java client and there are no plans to support Jakarta EE 9 in it.

@marcusdacoregio marcusdacoregio added the type: task A general task label Oct 25, 2021
@marcusdacoregio marcusdacoregio added this to the 6.x milestone Oct 25, 2021
@marcusdacoregio marcusdacoregio self-assigned this Oct 25, 2021
rwinch pushed a commit that referenced this issue Oct 25, 2021
rwinch pushed a commit that referenced this issue Oct 26, 2021
@Emkas
Copy link
Contributor

Emkas commented Nov 2, 2021

Hello @marcusdacoregio,
Since me and my team have been using spring-security-cas (and cas-client-core) for years, can you tell us is there any link or resource online about Apereo doesn't want to support Jakarta EE 9 so we could read this and maybe debate about it? I saw this issue last week and I tried to find some info about this, but with no results.

@marcusdacoregio
Copy link
Contributor Author

Hi @Emkas, thanks for reaching out.

I tried to get in touch with them through some emails sent to their mailing lists, but it seems that those lists are not working.

Disabling the CAS module is not a definitive action and can be reverted if they release a version of their library that supports Jakarta EE 9.

Any help to get in touch with them would be awesome if you are interested.

@Emkas
Copy link
Contributor

Emkas commented Nov 2, 2021

OK, so it's based on silence, not on some plain statement. I was afraid of that.

Not so long ago I've sent some PR's in java-cas-client. For a start. To see how their are working (as I did in Spring Security :-)). I get no feedback. And well.... java-cas-client looks like an abandoned project, only changes that are approved are PR's from bots with dependency updates (separate branches and then merged - or not - to the master - by another bot?).

I'm interested, but unfortunately I don't have any inside knowledge or contacts.


I've starting to write this message and in the meantime, I've bump my PR in java-cas-client and it was merged within 3 minutes :-) Maybe not the best place, but I'll try to get some info there.

@Emkas
Copy link
Contributor

Emkas commented Nov 2, 2021

From apereo/java-cas-client#612 (comment)

As you surely know, this is an open-source project. There are no "plans" to do anything. Plans are made when someone shows up with a pull request, or someone pays someone to work on a pull request. Since those are unknown, I cant tell you about a pre-defined plan. All I can tell you is, atm, there are no plans since there is no pending PR, and AFAIK, nobody is paid to work on that feature. (Even pending PRs would be reviewed as time allows)

Support for Jakarta generally would happen around the time of Spring Boot 3 and Spring 6. Too soon to "plan" for anything.

@marcusdacoregio
Copy link
Contributor Author

Thank you for getting that information with the maintainers.

I guess that there isn't much to do from our side but wait on them. We have some time before next Spring's major versions go GA.

@xhaggi
Copy link
Contributor

xhaggi commented Aug 9, 2022

The CAS client has just been updated to JDK 17 + Jakarta EE. I've create an issue #11674 to re-add the CAS module.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type: task A general task
Projects
None yet
Development

No branches or pull requests

4 participants