-
Notifications
You must be signed in to change notification settings - Fork 21
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Array Quantities #111
Array Quantities #111
Conversation
…dels into ArrayQuanitites
Codecov ReportBase: 76.73% // Head: 76.79% // Increases project coverage by
Additional details and impacted files@@ Coverage Diff @@
## main #111 +/- ##
==========================================
+ Coverage 76.73% 76.79% +0.06%
==========================================
Files 15 15
Lines 2063 2077 +14
==========================================
+ Hits 1583 1595 +12
- Misses 480 482 +2
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
ca58b48
to
546ddf4
Compare
I have sorted out all the remaining units, and this aligns with RAD-195. The n_ints questions point to the need for a new ticket: there are n_int variables throughout the file that should be cleaned up (as Roman only has one integration). |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me. I marked one comment as vestigial.
Ticket to support quantities for data arrays in the pipeline.