Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Array Quantities #111

Merged
merged 43 commits into from
Dec 15, 2022
Merged

Array Quantities #111

merged 43 commits into from
Dec 15, 2022

Conversation

PaulHuwe
Copy link
Collaborator

Ticket to support quantities for data arrays in the pipeline.

@codecov
Copy link

codecov bot commented Dec 5, 2022

Codecov Report

Base: 76.73% // Head: 76.79% // Increases project coverage by +0.06% 🎉

Coverage data is based on head (35bc229) compared to base (e6deb8e).
Patch coverage: 96.22% of modified lines in pull request are covered.

❗ Current head 35bc229 differs from pull request most recent head 8491b31. Consider uploading reports for the commit 8491b31 to get more accurate results

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #111      +/-   ##
==========================================
+ Coverage   76.73%   76.79%   +0.06%     
==========================================
  Files          15       15              
  Lines        2063     2077      +14     
==========================================
+ Hits         1583     1595      +12     
- Misses        480      482       +2     
Impacted Files Coverage Δ
src/roman_datamodels/testing/factories.py 98.40% <90.47%> (-0.60%) ⬇️
src/roman_datamodels/stnode.py 89.54% <100.00%> (+0.02%) ⬆️
src/roman_datamodels/testing/utils.py 99.82% <100.00%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@PaulHuwe PaulHuwe marked this pull request as ready for review December 5, 2022 00:07
@PaulHuwe
Copy link
Collaborator Author

PaulHuwe commented Dec 7, 2022

I have sorted out all the remaining units, and this aligns with RAD-195.

The n_ints questions point to the need for a new ticket: there are n_int variables throughout the file that should be cleaned up (as Roman only has one integration).

@PaulHuwe PaulHuwe marked this pull request as ready for review December 11, 2022 20:09
@PaulHuwe PaulHuwe self-assigned this Dec 11, 2022
@PaulHuwe PaulHuwe requested a review from schlafly December 15, 2022 01:10
Copy link
Collaborator

@schlafly schlafly left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me. I marked one comment as vestigial.

src/roman_datamodels/testing/factories.py Outdated Show resolved Hide resolved
@PaulHuwe PaulHuwe merged commit fa016af into spacetelescope:main Dec 15, 2022
@nden nden mentioned this pull request Dec 23, 2022
WilliamJamieson added a commit to WilliamJamieson/roman_datamodels that referenced this pull request Apr 27, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants