Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Explore Array Quanitites #582

Closed
stscijgbot-rstdms opened this issue Oct 14, 2022 · 7 comments · Fixed by spacetelescope/stcal#124
Closed

Explore Array Quanitites #582

stscijgbot-rstdms opened this issue Oct 14, 2022 · 7 comments · Fixed by spacetelescope/stcal#124
Assignees

Comments

@stscijgbot-rstdms
Copy link
Collaborator

Issue RCAL-406 was created on JIRA by Paul Huwe:

Investigate the Impact of Using Quantities for Arrays throughout the Roman calibration pipeline.

@stscijgbot-rstdms
Copy link
Collaborator Author

Comment by Paul Huwe on JIRA:

Thus far, initial investigations look feasible, however we need to expand ASDF unit support to include the following:

astropy.units.DN

astropy.units.electron (for astropy.units.electron / astropy.units.s)

So that models will serialize. 

 

 

@stscijgbot-rstdms
Copy link
Collaborator Author

Comment by Paul Huwe on JIRA:

This is implemented in the following PRs. They are still in draft status while we review them, as this won't be in the next release. These PRs pass all unit tests throughout the entire Roman Calibration Pipeline suite and JWST. Note that the changes for STCAL are the type that will be needed for each reference file that gets turned to quantities in the future.

 

Draft PRs:

STCAL:
spacetelescope/stcal#124

 

RAD:

spacetelescope/rad#192

 

RDM:

spacetelescope/roman_datamodels#111

 

RCAL:
#602

 

@stscijgbot-rstdms
Copy link
Collaborator Author

Comment by Paul Huwe on JIRA:

The STCAL PR has been merged.

@stscijgbot-rstdms
Copy link
Collaborator Author

Comment by Paul Huwe on JIRA:

The RAD PR has been merged.

@stscijgbot-rstdms
Copy link
Collaborator Author

Comment by Paul Huwe on JIRA:

The RDM PR has been merged.

@stscijgbot-rstdms
Copy link
Collaborator Author

Comment by Paul Huwe on JIRA:

Work on the RomanCAL PR is done, but it is waiting on new input files before merging.

@stscijgbot-rstdms
Copy link
Collaborator Author

Comment by Paul Huwe on JIRA:

This was merged and unmerged - the new PR is here: #616

 

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants