Remove enum enforcement
#112
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportBase: 76.73% // Head: 76.60% // Decreases project coverage by
Additional details and impacted files@@ Coverage Diff @@
## main #112 +/- ##
==========================================
- Coverage 76.73% 76.60% -0.13%
==========================================
Files 15 15
Lines 2076 2056 -20
==========================================
- Hits 1593 1575 -18
+ Misses 483 481 -2
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
WilliamJamieson
force-pushed
the
bugfix/enum
branch
from
b748df1 to
8a2acde
Compare
nden
approved these changes
Jan 4, 2023
WilliamJamieson
force-pushed
the
bugfix/enum
branch
from
8a2acde to
a29fb35
Compare
Done |
Also added entry for PR spacetelescope#100 as it was missing
WilliamJamieson
force-pushed
the
bugfix/enum
branch
from
a29fb35 to
09c1030
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
With ASDF 2.14.2, the bug in
enumfor schemas as fixed so that we can useenumfor tagged-string objects inrad. This means it is no-longer necessary to enforce theseenumvalues throughroman_datamodels. Thus this PR cleans-uproman_datamodelsby removing this unnecessary code.Note that this PR depends on:
enumrad#194 (updates to schemas to re-enableenumin those schemas.