-
Notifications
You must be signed in to change notification settings - Fork 21
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
move build configuration into pyproject.toml
#100
Conversation
fccc3da
to
6005f14
Compare
Needs a slight modification to work with pyproject.toml configured projects, |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #100 +/- ##
==========================================
- Coverage 76.78% 76.73% -0.05%
==========================================
Files 15 15
Lines 2076 2076
==========================================
- Hits 1594 1593 -1
- Misses 482 483 +1 ☔ View full report in Codecov by Sentry. |
Note #108 |
c66eb10
to
5dd4797
Compare
4c63e14
to
2189b1b
Compare
2189b1b
to
85d4897
Compare
Co-authored-by: William Jamieson <[email protected]>
85d4897
to
940354c
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Also added entry for PR spacetelescope#100 as it was missing
similar to spacetelescope/romancal#512
setuptools
now supports the[project]
table, which is defined by PEP621.Additionally,
setuptools
now supports its own entry inpyproject.toml
called[tool.setuptools]
(pypa/setuptools#1688, https://setuptools.pypa.io/en/latest/userguide/pyproject_config.html#setuptools-specific-configuration); however, it comes with the following disclaimer:This functionality with
setuptools
will likely be supported upon the release of Python 3.11, with its native implementation oftomli
Given this, we can attempt to consolidate the build configuration into a single
pyproject.toml
file that can possibly be read by other build systems in the future.