Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

move build configuration into pyproject.toml #100

Merged
merged 12 commits into from
Jan 5, 2023

Conversation

zacharyburnett
Copy link
Collaborator

similar to spacetelescope/romancal#512

setuptools now supports the [project] table, which is defined by PEP621.

Additionally, setuptools now supports its own entry in pyproject.toml called [tool.setuptools] (pypa/setuptools#1688, https://setuptools.pypa.io/en/latest/userguide/pyproject_config.html#setuptools-specific-configuration); however, it comes with the following disclaimer:

Support for declaring configurations not standardized by PEP 621 (i.e. the [tool.setuptools] table), is still in beta stage and might change in future releases.

This functionality with setuptools will likely be supported upon the release of Python 3.11, with its native implementation of tomli

Given this, we can attempt to consolidate the build configuration into a single pyproject.toml file that can possibly be read by other build systems in the future.

@WilliamJamieson
Copy link
Collaborator

Needs a slight modification to work with pyproject.toml configured projects, isolated_build = True needs to be added see: https://github.com/asdf-format/asdf/blob/3e6679f310cdaabddb55761880c952d0a5199b35/tox.ini#L1-L3.

@zacharyburnett zacharyburnett marked this pull request as draft September 14, 2022 14:29
@codecov
Copy link

codecov bot commented Sep 14, 2022

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 76.73%. Comparing base (5c9c58f) to head (940354c).
Report is 236 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #100      +/-   ##
==========================================
- Coverage   76.78%   76.73%   -0.05%     
==========================================
  Files          15       15              
  Lines        2076     2076              
==========================================
- Hits         1594     1593       -1     
- Misses        482      483       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

docs/conf.py Outdated Show resolved Hide resolved
pyproject.toml Outdated Show resolved Hide resolved
@nden
Copy link
Collaborator

nden commented Sep 30, 2022

Note #108

pyproject.toml Outdated Show resolved Hide resolved
Copy link
Collaborator

@WilliamJamieson WilliamJamieson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@zacharyburnett zacharyburnett merged commit 35d88b2 into spacetelescope:main Jan 5, 2023
@zacharyburnett zacharyburnett deleted the pep621 branch January 5, 2023 18:17
WilliamJamieson added a commit to WilliamJamieson/roman_datamodels that referenced this pull request Jan 5, 2023
Also added entry for PR spacetelescope#100 as it was missing
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants