-
Notifications
You must be signed in to change notification settings - Fork 28
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
move build configuration into pyproject.toml
#512
move build configuration into pyproject.toml
#512
Conversation
Codecov ReportBase: 81.83% // Head: 81.22% // Decreases project coverage by
Additional details and impacted files@@ Coverage Diff @@
## main #512 +/- ##
==========================================
- Coverage 81.83% 81.22% -0.61%
==========================================
Files 39 39
Lines 1167 1156 -11
==========================================
- Hits 955 939 -16
- Misses 212 217 +5
*This pull request uses carry forward flags. Click here to find out more.
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
c8dfb1f
to
eddf10c
Compare
dab2f82
to
aaf6384
Compare
aaf6384
to
c839bdb
Compare
e442078
to
918028f
Compare
918028f
to
f9d3f21
Compare
a826f41
to
9a13b1b
Compare
9a13b1b
to
4a08966
Compare
4a08966
to
767b907
Compare
update usage of `setup.cfg` throughout codebase
b6324e9
to
86c2f70
Compare
copying from the Now that Python 3.11 includes If [tool.setuptools]
zip-safe = false
[tool.setuptools.packages.find]
[tool.setuptools.package-data]
# package_data values are glob patterns relative to each specific subpackage.
'*' = [
'*.fits',
'*.txt',
'*.inc',
'*.cfg',
'*.csv',
'*.yaml',
'*.json',
'*.asdf',
] The |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looking good to me.
Description
setuptools
now supports the[project]
table, which is defined by PEP621.Additionally,
setuptools
now supports its own entry inpyproject.toml
called[tool.setuptools]
(pypa/setuptools#1688, https://setuptools.pypa.io/en/latest/userguide/pyproject_config.html#setuptools-specific-configuration); however, it comes with the following disclaimer:Given this, we can attempt to consolidate the build configuration into a single
pyproject.toml
file that can possibly be read by other build systems in the future.Checklist