Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix bug in amp33 shape introduced in #111 #166

Merged

Conversation

WilliamJamieson
Copy link
Collaborator

In #111, a small bug was introduced in the shape of the amp33 shape for the ramp model. This PR corrects this.

Checklist

@WilliamJamieson WilliamJamieson requested a review from a team as a code owner April 27, 2023 17:26
Copy link
Collaborator

@ddavis-stsci ddavis-stsci left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Look Good

Copy link
Collaborator

@PaulHuwe PaulHuwe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please be sure this does not break RCAL Unit or Regression tests.. it possibly could.

Also, changelog?

@WilliamJamieson
Copy link
Collaborator Author

Not sure this warrants a changelog but I'll add one.

@WilliamJamieson
Copy link
Collaborator Author

Please be sure this does not break RCAL Unit or Regression tests.. it possibly could.

Well if it breaks anything in RCAL then that test is broken.

@codecov
Copy link

codecov bot commented Apr 27, 2023

Codecov Report

Patch and project coverage have no change.

Comparison is base (683fda5) 96.73% compared to head (01ef4f2) 96.73%.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #166   +/-   ##
=======================================
  Coverage   96.73%   96.73%           
=======================================
  Files           9        9           
  Lines        1101     1101           
=======================================
  Hits         1065     1065           
  Misses         36       36           

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@PaulHuwe
Copy link
Collaborator

Please be sure this does not break RCAL Unit or Regression tests.. it possibly could.

Well if it breaks anything in RCAL then that test is broken.

Yes, and we'd need to fix that test before merging this, to ensure we don't break the nightly regression tests.

@WilliamJamieson
Copy link
Collaborator Author

No failures: https://plwishmaster.stsci.edu:8081/job/RT/job/Roman-Developers-Pull-Requests/148/

Copy link
Collaborator

@PaulHuwe PaulHuwe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@WilliamJamieson WilliamJamieson merged commit 424dbd9 into spacetelescope:main Apr 28, 2023
@WilliamJamieson WilliamJamieson deleted the bugfix/amp33_shape branch April 28, 2023 19:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants