Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

2024.4 #1341

Merged
merged 5 commits into from
May 7, 2024
Merged

2024.4 #1341

merged 5 commits into from
May 7, 2024

Conversation

javierggt
Copy link
Contributor

@javierggt javierggt commented Apr 29, 2024

ska3-flight 2024.4

This PR includes:

  • acis_thermal_check
    • now uses chandra_limits package (acis_thermal_check PR 71)
    • first version of 1DPAMYT model (acis_thermal_check PR 72)
  • cheta.
    • updated HRMA OHRTHR data to use WIDE mode.
    • Fix Computed_Quat MSID in cases when there are bad data in the fetch range.
  • kadi. Remove commands v1.
  • proseco. Implement acquisition box overlap penalty

Interface Impacts:

  • Commands v1 has been deprecated for a long time and now it is fully removed. The configuration setting commands_version is removed and the environment variable KADI_COMMANDS_VERSION no longer has any effect.
  • Proseco will change which acquisition stars are selected or modify box sizes in cases where an overlapping box would have been chosen. While this code will become operation for load checking, the corresponding changes that affect load creation will not become operational until Matlab 2024_030 is promoted. As a result, there might be some discrepancies between star selection and load checking until then.
  • acis_thermal_check
    • The 1DPAMYT model will have a calling sequence similar to 1DPAMZT
    • The table reporting violations on the webpages has changed slightly, but is human-read. Plots show limit lines as a function of time instead of every limit line across the whole plot; also human-read.

Testing:

skare3 dashboard and test result password at https://icxc.cfa.harvard.edu/aspect/skare3_dash_cred.txt

The latest release candidates will be installed in /proj/sot/ska3/test on HEAD, and all release candidates will be available for testing from the usual channels:

conda create -n ska3-flight-2024.4rc# --override-channels \
  -c https://icxc.cfa.harvard.edu/aspect/ska3-conda/flight \
  -c https://icxc.cfa.harvard.edu/aspect/ska3-conda/test \
  ska3-flight==2024.4rc#

Review

All operations critical or impacting PR's are independently and carefully reviewed. For other PR's the level of detail for review is calibrated to operations criticality. Some PR's that are confined to aspect-team-specific processing may have little to no independent review.

Deployment

ska3-flight 2024.4 will be promoted to flight conda channel and installed on HEAD and GRETA Linux upon approval of FSDS Jira ticket.

Code changes

ska3-core changes (2024.2 -> 2024.4rc3)

On OSX, libblas uses libopenblas instead of MKL.

ska3-flight changes (2024.1 -> 2024.4rc3)

Updated Packages

  • acis_thermal_check: 4.8.1 -> 5.1.0 (4.8.1 -> 5.0.0 -> 5.1.0)
    • PR 71 (John ZuHone): Use chandra limits
    • PR 72 (None): First version of the 1DPAMYT model and setup.py mods
  • agasc: 4.18.2 -> 4.18.3 (4.18.2 -> 4.18.3)
    • PR 172 (Javier Gonzalez): remove statements forcing kadi commands v1
  • chandra_limits: 0.5.0 -> 0.8.0 (0.5.0 -> 0.6.0 -> 0.7.0 -> 0.7.1 -> 0.7.2 -> 0.8.0)
    • PR 8 (John ZuHone): Chandra models chars
    • PR 6 (John ZuHone): Black ruff
    • PR 11 (John ZuHone): Plotting nits
    • PR 10 (John ZuHone): Tests update
    • PR 12 (John ZuHone): start_time bug fix
    • PR 13 (John ZuHone): Catch ValueError in case local obscat has not been updated
    • PR 14 (None): Adding the new Chandra Limits capability to 1DPAMYT model; fixing .p…
  • cheta: 4.61.2 -> 4.62.0 (4.61.2 -> 4.62.0)
    • PR 261 (Jean Connelly): Update HRMA OHRTHR data to use WIDE mode values PR-575
    • PR 259 (Tom Aldcroft): Modernize
    • PR 260 (Tom Aldcroft): Fix computed Comp_Quat class and close pickle files
    • PR 258 (Tom Aldcroft): Convert remaining np.bool to bool
  • find_attitude: 3.4.3 -> 3.4.4 (3.4.3 -> 3.4.4)
    • PR 27 (Tom Aldcroft): Ruff and modernize
  • fot-matlab: 2.3.0 -> 2.4.0 (2.3.0 -> 2.4.0)
    • PR 26 (James Kristoff): Support parsing YAML comments from file or as raw text
    • PR 25 (James Kristoff): Add support for parsing YAML text from OR List Comments
  • kadi: 7.9.0 -> 7.10.0 (7.9.0 -> 7.10.0)
    • PR 328 (Tom Aldcroft): Remove commands v1 from kadi
  • mica: 4.35.1 -> 4.35.2 (4.35.1 -> 4.35.2)
    • PR 298 (Jean Connelly): Don't warn if kadi user can't access db
    • PR 297 (Jean Connelly): Handle filling aca image array differently
    • PR 295 (Jean Connelly): Update one remaining sybase call to use sqsh
    • PR 296 (Jean Connelly): Remove np.str calls
  • parse_cm: 3.14.2 -> 3.14.3 (3.14.2 -> 3.14.3)
    • PR 51 (Tom Aldcroft): Change np.bool to bool and add test
  • proseco: 5.12.0 -> 5.13.0 (5.12.0 -> 5.13.0)
    • PR 394 (Tom Aldcroft): Implement acquisition box overlap penalty
    • PR 395 (Tom Aldcroft): Ruff format and linting
  • ska3-core: 2024.1 -> 2024.4rc3
  • sparkles: 4.26.0 -> 4.26.1 (4.26.0 -> 4.26.1)
    • PR 210 (Tom Aldcroft): ruff formatting fixes
    • PR 209 (Jean Connelly): Update tests for proseco p2 overlap change
  • starcheck: 14.8.0 -> 14.8.1 (14.8.0 -> 14.8.1)
    • PR 440 (Jean Connelly): Add notebook to make quick regress scripts
  • xija: 4.31.2 -> 4.31.3 (4.31.2 -> 4.31.3)
    • PR 137 (Tom Aldcroft): Change np.float to float

Related Issues

Fixes #1308
Fixes #1323
Fixes #1324
Fixes #1325
Fixes #1326
Fixes #1327
Fixes #1328
Fixes #1329
Fixes #1330
Fixes #1331
Fixes #1332
Fixes #1333
Fixes #1340

@javierggt javierggt added this to the 2024.4 milestone Apr 29, 2024
@jeanconn
Copy link
Contributor

Is this 2024.4?

@javierggt javierggt changed the title 2024.3 2024.4 Apr 30, 2024
@javierggt
Copy link
Contributor Author

yes, the branch is correct for 2024, the title and description were wrong.

@javierggt javierggt merged commit e62c650 into master May 7, 2024
12 of 14 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment