-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update HRMA OHRTHR data to use WIDE mode values PR-575 #261
Conversation
4c50d1d
to
672b09b
Compare
|
||
msid = { | ||
"pr-361": "4OAVOBAT", | ||
"pr-575": "4OAVHRMT", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm just guessing that 4OAVHRMT needs the wide mode treatment at this point.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@matthewdahmer or @christian-anderson, should 4OAVHRMT in the cheta cxc archive be switched to be the from-WIDE values after PR-575? I wasn't sure what it was an average over, but saw that it was read out and checked as part of the CAP.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@jeanconn yes, can confirm 4OAVHRMT should also be switched to WIDE values (it's the OBC calculated HRMA Average temerature). Thanks!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It doesn't look like 4OAVHRMT was in the list that went to DS for their CALDB / processing changes, so I don't know what behavior to expect downstream.
415c5f8
to
2756811
Compare
2756811
to
4189e47
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Super job @jeanconn! This all looks good and convincing to me, thanks for the excellent validation plots and the good idea to run the converter code that way.
Description
Update HRMA OHRTHR data to use WIDE mode values PR-575
See previous PRs #102 #127 and #142
Interface impacts
Testing
Unit tests
Independent check of unit tests by [REVIEWER NAME]
Functional tests
Times checked and verified with included notebook.