Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update HRMA OHRTHR data to use WIDE mode values PR-575 #261

Merged
merged 5 commits into from
Apr 14, 2024

Conversation

jeanconn
Copy link
Contributor

@jeanconn jeanconn commented Apr 11, 2024

Description

Update HRMA OHRTHR data to use WIDE mode values PR-575

See previous PRs #102 #127 and #142

Interface impacts

Testing

Unit tests

  • Linux
ska3-jeanconn-fido> git rev-parse HEAD
4a49500c4a7601b4c132373df25bde9b6b3f9dcc
ska3-jeanconn-fido> pytest
====================================================== test session starts ======================================================
platform linux -- Python 3.11.8, pytest-7.4.4, pluggy-1.4.0
rootdir: /proj/sot/ska/jeanproj/git
configfile: pytest.ini
plugins: anyio-4.3.0, timeout-2.2.0
collected 174 items                                                                                                             

cheta/tests/test_comps.py ............................................................                                    [ 34%]
cheta/tests/test_data_source.py .........                                                                                 [ 39%]
cheta/tests/test_fetch.py ................................                                                                [ 58%]
cheta/tests/test_intervals.py .........................                                                                   [ 72%]
cheta/tests/test_orbit.py .                                                                                               [ 72%]
cheta/tests/test_remote_access.py ......                                                                                  [ 76%]
cheta/tests/test_sync.py ........                                                                                         [ 81%]
cheta/tests/test_units.py ...........                                                                                     [ 87%]
cheta/tests/test_units_reversed.py ...........                                                                            [ 93%]
cheta/tests/test_utils.py ...........                                                                                     [100%]

================================================ 174 passed in 343.99s (0:05:43)

Independent check of unit tests by [REVIEWER NAME]

  • [PLATFORM]:

Functional tests

Times checked and verified with included notebook.

@jeanconn jeanconn force-pushed the more-hrma-wide branch 3 times, most recently from 4c50d1d to 672b09b Compare April 11, 2024 16:19

msid = {
"pr-361": "4OAVOBAT",
"pr-575": "4OAVHRMT",
Copy link
Contributor Author

@jeanconn jeanconn Apr 11, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm just guessing that 4OAVHRMT needs the wide mode treatment at this point.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@matthewdahmer or @christian-anderson, should 4OAVHRMT in the cheta cxc archive be switched to be the from-WIDE values after PR-575? I wasn't sure what it was an average over, but saw that it was read out and checked as part of the CAP.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@jeanconn yes, can confirm 4OAVHRMT should also be switched to WIDE values (it's the OBC calculated HRMA Average temerature). Thanks!

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It doesn't look like 4OAVHRMT was in the list that went to DS for their CALDB / processing changes, so I don't know what behavior to expect downstream.

@jeanconn jeanconn force-pushed the more-hrma-wide branch 2 times, most recently from 415c5f8 to 2756811 Compare April 11, 2024 17:38
@jeanconn jeanconn marked this pull request as ready for review April 12, 2024 19:48
@jeanconn jeanconn marked this pull request as draft April 12, 2024 19:59
@jeanconn jeanconn marked this pull request as ready for review April 12, 2024 20:18
Copy link
Member

@taldcroft taldcroft left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Super job @jeanconn! This all looks good and convincing to me, thanks for the excellent validation plots and the good idea to run the converter code that way.

@jeanconn jeanconn merged commit 5e546ef into master Apr 14, 2024
2 checks passed
@jeanconn jeanconn deleted the more-hrma-wide branch April 14, 2024 22:33
This was referenced Apr 17, 2024
@javierggt javierggt mentioned this pull request May 1, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants