Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ruff format and linting #395

Merged
merged 3 commits into from
Mar 14, 2024
Merged

Ruff format and linting #395

merged 3 commits into from
Mar 14, 2024

Conversation

taldcroft
Copy link
Member

@taldcroft taldcroft commented Mar 11, 2024

Description

This uses sot/skare3#1269 as the template.

Interface impacts

Testing

Unit tests

  • Mac
================================================ test session starts =================================================
platform darwin -- Python 3.11.8, pytest-7.4.4, pluggy-1.4.0
rootdir: /Users/aldcroft/git
configfile: pytest.ini
plugins: timeout-2.2.0, anyio-4.3.0
collecting ... Intel MKL WARNING: Support of Intel(R) Streaming SIMD Extensions 4.2 (Intel(R) SSE4.2) enabled only processors has been deprecated. Intel oneAPI Math Kernel Library 2025.0 will require Intel(R) Advanced Vector Extensions (Intel(R) AVX) instructions.
Intel MKL WARNING: Support of Intel(R) Streaming SIMD Extensions 4.2 (Intel(R) SSE4.2) enabled only processors has been deprecated. Intel oneAPI Math Kernel Library 2025.0 will require Intel(R) Advanced Vector Extensions (Intel(R) AVX) instructions.
collected 165 items                                                                                                  

proseco/tests/test_acq.py ....................................                                                 [ 21%]
proseco/tests/test_catalog.py ..........................................                                       [ 47%]
proseco/tests/test_core.py ...........................                                                         [ 63%]
proseco/tests/test_diff.py ......                                                                              [ 67%]
proseco/tests/test_fid.py ...............                                                                      [ 76%]
proseco/tests/test_guide.py ...................................                                                [ 97%]
proseco/tests/test_mon_full_cat.py ....                                                                        [100%]

================================================ 165 passed in 29.33s ================================================
(ska3-flight-2024.1rc4) ➜  proseco git:(ruff) git rev-parse HEAD                     
f0b09d8559778ff1587e00563d71a93e4e1dea7e

Independent check of unit tests by Jean

  • Linux in speedy test
jeanconn-fido> source /proj/sot/ska3/test/bin/ska_envs.sh
jeanconn-fido> pytest
============================================================= test session starts =============================================================
platform linux -- Python 3.11.8, pytest-7.4.4, pluggy-1.4.0
rootdir: /proj/sot/ska/jeanproj/git
configfile: pytest.ini
plugins: anyio-4.3.0, timeout-2.2.0
collected 165 items                                                                                                                           

proseco/tests/test_acq.py ....................................                                                                          [ 21%]
proseco/tests/test_catalog.py ..........................................                                                                [ 47%]
proseco/tests/test_core.py ...........................                                                                                  [ 63%]
proseco/tests/test_diff.py ......                                                                                                       [ 67%]
proseco/tests/test_fid.py ...............                                                                                               [ 76%]
proseco/tests/test_guide.py ...................................                                                                         [ 97%]
proseco/tests/test_mon_full_cat.py ....                                                                                                 [100%]

============================================================== warnings summary ===============================================================
../../../../ska3/test/lib/python3.11/site-packages/tables/node.py:251: 1 warning
proseco/proseco/tests/test_acq.py: 34 warnings
proseco/proseco/tests/test_catalog.py: 52 warnings
proseco/proseco/tests/test_core.py: 17 warnings
proseco/proseco/tests/test_fid.py: 18 warnings
proseco/proseco/tests/test_guide.py: 108 warnings
proseco/proseco/tests/test_mon_full_cat.py: 5 warnings
  /proj/sot/ska3/test/lib/python3.11/site-packages/tables/node.py:251: DeprecationWarning: `alltrue` is deprecated as of NumPy 1.25.0, and will be removed in NumPy 2.0. Please use `all` instead.
    self._v_objectid = self._g_open()

-- Docs: https://docs.pytest.org/en/stable/how-to/capture-warnings.html
================================================ 165 passed, 235 warnings in 135.18s (0:02:15) ================================================
jeanconn-fido> git rev-parse HEAD
f0b09d8559778ff1587e00563d71a93e4e1dea7e

Functional tests

No functional testing.

@taldcroft taldcroft merged commit 89e5b00 into master Mar 14, 2024
2 checks passed
@taldcroft taldcroft deleted the ruff branch March 14, 2024 15:40
@javierggt javierggt mentioned this pull request May 1, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants