remove statements forcing kadi commands v1

[javierggt]

Description

This removes statements forcing the use of kadi commands v1 in some top-level scripts.

The AGASC supplemet processing uses kadi.commands.get_observations and kadi.commands.get_starcats_as_table. Both are commands v2 functions, not present in v1. As a result, the statements removed in this PR do not affect anything within AGASC.

I ran the following command using this branch without error:

python -m agasc.scripts.update_mag_supplement --start 2021:011 --stop 2021:012

Also, weekly processing has already been running without issues for two week after moving away the commands v1 files.

Interface impacts

Testing

Unit tests

• No unit tests
• Mac
• Linux
• Windows

Independent check of unit tests by Jean

• Linux

(ska3-masters) jeanconn-fido> pytest
================================================== test session starts ==================================================
platform linux -- Python 3.11.8, pytest-8.0.2, pluggy-1.4.0
rootdir: /proj/sot/ska/jeanproj/git
configfile: pytest.ini
plugins: timeout-2.2.0, anyio-4.3.0
collected 72 items                                                                                                      

agasc/tests/test_agasc_1.py .....                                                                                 [  6%]
agasc/tests/test_agasc_2.py ..........................................                                            [ 65%]
agasc/tests/test_agasc_healpix.py ...........                                                                     [ 80%]
agasc/tests/test_obs_status.py ..............                                                                     [100%]

============================================ 72 passed in 113.70s (0:01:53) =============================================
(ska3-masters) jeanconn-fido> git rev-parse HEAD
4811f585cb067968426daa5672180e3067813d86

Functional tests

No functional testing.

[taldcroft]

@javierggt - This just needs a statement in the description reflecting what you said verbally today -- that you ran processing on HEAD with the flight code and it succeeded. Given that commands v1 is broken by virtue of changing the data file names, I think this is sufficient to demonstrate that the configuration lines being removed have no impact.

[jeanconn]

#168 has already been reviewed, so I think the open PR is really just the other commit 9e1d5d9 .

[javierggt]

ha, yes. I thought Github would have figured that out.