-
Notifications
You must be signed in to change notification settings - Fork 1.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[wol] Extend wol to support sending magic pattern in udp payload #20523
Conversation
/azpw run Azure.sonic-buildimage |
/AzurePipelines run Azure.sonic-buildimage |
Azure Pipelines successfully started running 1 pipeline(s). |
const BROADCAST_MAC: [u8; 6] = [0xff, 0xff, 0xff, 0xff, 0xff, 0xff]; | ||
|
||
pub static VERBOSE_OUTPUT: Mutex<bool> = Mutex::new(false); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why using Mutex instead of a bool variable? Any race condition may happen?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Using mutex is safer although there is no race condition may happen
/azpw run Azure.sonic-buildimage |
/AzurePipelines run Azure.sonic-buildimage |
Azure Pipelines successfully started running 1 pipeline(s). |
Hi @yxieca, cloud you help merge this PR? thanks |
We extended wol tool to support sending magic pattern in udp paylod, and we need to add related tests into test plan. Related PRs: sonic-net/SONiC#1827, sonic-net/sonic-buildimage#20523 What is the motivation for this PR? We extended wol tool to support sending magic pattern in udp paylod, and we need to add related tests into test plan. How did you do it? Add udp related tests and give some demo commands.
We extended wol tool to support sending magic pattern in udp paylod, and we need to add related tests into test plan. Related PRs: sonic-net/SONiC#1827, sonic-net/sonic-buildimage#20523 What is the motivation for this PR? We extended wol tool to support sending magic pattern in udp paylod, and we need to add related tests into test plan. How did you do it? Add udp related tests and give some demo commands.
We extended wol tool to support sending magic pattern in udp paylod, and we need to add related tests into test plan. Related PRs: sonic-net/SONiC#1827, sonic-net/sonic-buildimage#20523 What is the motivation for this PR? We extended wol tool to support sending magic pattern in udp paylod, and we need to add related tests into test plan. How did you do it? Add udp related tests and give some demo commands.
…ic-net#20523) Why I did it Although the magic pattern is fixed, we can send the magic pattern in UDP payload to leverage the benefits of UDP. How I did it Add code to support sending payload in udp and provide CLI parameters for it. How to verify it Unit test and run tests in sonic-mgmt
We extended wol tool to support sending magic pattern in udp paylod, and we need to add related tests into test plan. Related PRs: sonic-net/SONiC#1827, sonic-net/sonic-buildimage#20523 What is the motivation for this PR? We extended wol tool to support sending magic pattern in udp paylod, and we need to add related tests into test plan. How did you do it? Add udp related tests and give some demo commands.
This cherry-pick depends on PR #21136 |
…ic-net#20523) Why I did it Although the magic pattern is fixed, we can send the magic pattern in UDP payload to leverage the benefits of UDP. How I did it Add code to support sending payload in udp and provide CLI parameters for it. How to verify it Unit test and run tests in sonic-mgmt
Cherry-pick PR to 202405: #21147 |
Why I did it
Although the magic pattern is fixed, we can send the magic pattern in UDP payload to leverage the benefits of UDP.
Work item tracking
How I did it
Add code to support sending payload in udp and provide CLI parameters for it.
How to verify it
Unit test and run tests in sonic-mgmt
Which release branch to backport (provide reason below if selected)
Tested branch (Please provide the tested image version)
Description for the changelog
Link to config_db schema for YANG module changes
A picture of a cute animal (not mandatory but encouraged)