Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[wol_test] Add udp related tests into wol test plan #15321

Merged
merged 7 commits into from
Nov 6, 2024

Conversation

w1nda
Copy link
Member

@w1nda w1nda commented Nov 1, 2024

Description of PR

Summary:
Fixes # (issue)
We extended wol tool to support sending magic pattern in udp paylod, and we need to add related tests into test plan.
Related PRs: sonic-net/SONiC#1827, sonic-net/sonic-buildimage#20523

Type of change

  • Bug fix
  • Testbed and Framework(new/improvement)
  • Test case(new/improvement)

Back port request

  • 202012
  • 202205
  • 202305
  • 202311
  • 202405

Approach

What is the motivation for this PR?

We extended wol tool to support sending magic pattern in udp paylod, and we need to add related tests into test plan.

How did you do it?

Add udp related tests and give some demo commands.

How did you verify/test it?

Any platform specific information?

Supported testbed topology if it's a new test case?

Documentation

@w1nda w1nda requested review from wangxin and yxieca as code owners November 1, 2024 03:44
@w1nda w1nda requested review from Blueve, lizhijianrd and Xichen96 and removed request for wangxin and yxieca November 1, 2024 03:45
@lizhijianrd
Copy link
Contributor

Hi @w1nda, below are my suggestions:

  1. For testcases 1~6, they are focusing on specific scenario, so add a L3 test would be enough. No need to test both ipv4 and ipv6.
  2. Add a group of testcases for newly introduced L3 parameters, like,
    1. Verify ip address can be both v4 and v6.
    2. Verify dest UDP port can be set properly.
    3. ...

@w1nda
Copy link
Member Author

w1nda commented Nov 5, 2024

Hi @w1nda, below are my suggestions:

  1. For testcases 1~6, they are focusing on specific scenario, so add a L3 test would be enough. No need to test both ipv4 and ipv6.

  2. Add a group of testcases for newly introduced L3 parameters, like,

    1. Verify ip address can be both v4 and v6.
    2. Verify dest UDP port can be set properly.
    3. ...

Thanks for suggestions.
For 1, we need to verify if wol works with both address family ipv4 and ipv6, so we can't just verify one of them.
For 2.*, these scenarios were covered by our testcases, because when we verify packet content, we will check those parameters indirectly. I think we can add a new standalone testcases to verify those parameters, i will add it.

@lizhijianrd
Copy link
Contributor

For 1, we need to verify if wol works with both address family ipv4 and ipv6, so we can't just verify one of them.

Thanks, this make sense. One more question, when implementing testcase, which IP address will you verify? unicast, broadcast or both? Can you update the testplan to clarify this?

@w1nda
Copy link
Member Author

w1nda commented Nov 5, 2024

For 1, we need to verify if wol works with both address family ipv4 and ipv6, so we can't just verify one of them.

Thanks, this make sense. One more question, when implementing testcase, which IP address will you verify? unicast, broadcast or both? Can you update the testplan to clarify this?

Good point, I think both are needed, I will add it.

@w1nda w1nda requested a review from lizhijianrd November 5, 2024 07:08
@wangxin wangxin merged commit 2aa8281 into sonic-net:master Nov 6, 2024
4 checks passed
veronica-arista pushed a commit to veronica-arista/sonic-mgmt that referenced this pull request Nov 7, 2024
We extended wol tool to support sending magic pattern in udp paylod, and we need to add related tests into test plan.
Related PRs: sonic-net/SONiC#1827, sonic-net/sonic-buildimage#20523

What is the motivation for this PR?
We extended wol tool to support sending magic pattern in udp paylod, and we need to add related tests into test plan.

How did you do it?
Add udp related tests and give some demo commands.
sreejithsreekumaran pushed a commit to sreejithsreekumaran/sonic-mgmt that referenced this pull request Nov 15, 2024
We extended wol tool to support sending magic pattern in udp paylod, and we need to add related tests into test plan.
Related PRs: sonic-net/SONiC#1827, sonic-net/sonic-buildimage#20523

What is the motivation for this PR?
We extended wol tool to support sending magic pattern in udp paylod, and we need to add related tests into test plan.

How did you do it?
Add udp related tests and give some demo commands.
yutongzhang-microsoft pushed a commit to yutongzhang-microsoft/sonic-mgmt that referenced this pull request Nov 21, 2024
We extended wol tool to support sending magic pattern in udp paylod, and we need to add related tests into test plan.
Related PRs: sonic-net/SONiC#1827, sonic-net/sonic-buildimage#20523

What is the motivation for this PR?
We extended wol tool to support sending magic pattern in udp paylod, and we need to add related tests into test plan.

How did you do it?
Add udp related tests and give some demo commands.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants