-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[wol HLD] Extend wol to support sending magic pattern in udp payload #1827
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
w1nda
changed the title
[wol HLD] Extend wol to support send magic pattern in udp payload
[wol HLD] Extend wol to support sending magic pattern in udp payload
Oct 11, 2024
lizhijianrd
reviewed
Oct 11, 2024
lizhijianrd
reviewed
Oct 11, 2024
lizhijianrd
approved these changes
Oct 17, 2024
Blueve
approved these changes
Oct 17, 2024
Hi @zhangyanzhao, cloud you help merge this PR? thanks |
8 tasks
wangxin
pushed a commit
to sonic-net/sonic-mgmt
that referenced
this pull request
Nov 6, 2024
We extended wol tool to support sending magic pattern in udp paylod, and we need to add related tests into test plan. Related PRs: sonic-net/SONiC#1827, sonic-net/sonic-buildimage#20523 What is the motivation for this PR? We extended wol tool to support sending magic pattern in udp paylod, and we need to add related tests into test plan. How did you do it? Add udp related tests and give some demo commands.
veronica-arista
pushed a commit
to veronica-arista/sonic-mgmt
that referenced
this pull request
Nov 7, 2024
We extended wol tool to support sending magic pattern in udp paylod, and we need to add related tests into test plan. Related PRs: sonic-net/SONiC#1827, sonic-net/sonic-buildimage#20523 What is the motivation for this PR? We extended wol tool to support sending magic pattern in udp paylod, and we need to add related tests into test plan. How did you do it? Add udp related tests and give some demo commands.
sreejithsreekumaran
pushed a commit
to sreejithsreekumaran/sonic-mgmt
that referenced
this pull request
Nov 15, 2024
We extended wol tool to support sending magic pattern in udp paylod, and we need to add related tests into test plan. Related PRs: sonic-net/SONiC#1827, sonic-net/sonic-buildimage#20523 What is the motivation for this PR? We extended wol tool to support sending magic pattern in udp paylod, and we need to add related tests into test plan. How did you do it? Add udp related tests and give some demo commands.
yutongzhang-microsoft
pushed a commit
to yutongzhang-microsoft/sonic-mgmt
that referenced
this pull request
Nov 21, 2024
We extended wol tool to support sending magic pattern in udp paylod, and we need to add related tests into test plan. Related PRs: sonic-net/SONiC#1827, sonic-net/sonic-buildimage#20523 What is the motivation for this PR? We extended wol tool to support sending magic pattern in udp paylod, and we need to add related tests into test plan. How did you do it? Add udp related tests and give some demo commands.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Although the magic pattern is fixed, we can send the magic pattern in UDP payload to leverage the benefits UDP.