Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add the option to checkout devices to more than one person #8002

Closed
wants to merge 873 commits into from

Conversation

Kurokat
Copy link

@Kurokat Kurokat commented Apr 28, 2020

To meet the needs of scenarios that have employees that work in alternative shifts and use the same devices.

Not sure If this is the right place to create the pull, because I am not able to create a new one in master > develop.

@Kurokat Kurokat requested review from snipe and uberbrady as code owners April 28, 2020 14:43
@mnemonicly
Copy link
Contributor

mnemonicly commented Apr 30, 2020

Hello,

It looks like this needs to be rebased against the current develop--there's a lot of extra noise here and it's hard to see what your changes actually are. Can you take a look and do this? (Same with #7975)

@snipe
Copy link
Owner

snipe commented Jul 17, 2020

This would definitely need a rebase before we can look at this, as I'm seeing a lot of our changes in here instead of just yours. That said, I'm not sure this is a feature we really want. If two people are assigned an asset, who is actually responsible for that asset if it is lost, stolen or damaged?

snipe and others added 28 commits October 9, 2020 17:29
We shouldn’t have to do this, but…
…ation_fsckery

Fixed #8513 - Manually created oauth tables
Ensure misdefined active flags will not prevent user syncing
* trustedproxy.php sets 'proxies' again according to
  env('APP_TRUSTED_PROXIES') again
Fixed #8543: Change trustedproxy.php to read env('APP_TRUSTED_PROXIES') again
…-dark-green-skin

fixed the Green skin (dark mode) color scheme on the importer page and asset table
Add a dirtiness check to slim down JSON LDAP sync summaries
@uberbrady
Copy link
Collaborator

I'm sorry, but we can't accept this - Snipe-IT fundamentally assumes that an asset can only be ever checked out to one 'thing' at a time.

@uberbrady uberbrady closed this Oct 23, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

9 participants