Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed #8543: Change trustedproxy.php to read env('APP_TRUSTED_PROXIES') again #8557

Merged
merged 1 commit into from
Oct 21, 2020
Merged

Conversation

fashberg
Copy link
Contributor

  • trustedproxy.php sets 'proxies' again according to
    env('APP_TRUSTED_PROXIES') again

Description

copying APP_TRUSTED_PROXIES from ENV to settings has been removed at commit 533649f

Diff:
533649f#diff-65b9650370ce063c0ae4c2d172d40fb6aafd2d2e8fe478dae7da21732d4d36dd

This patch undoes that change so snipe-it can now work in docker again!

Fixes #8543
Closes PR #8556 (master<-master) - here develop<-develop as requested in PR Guide)

Type of change

Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

How Has This Been Tested?

Test Configuration: official docker image

Checklist:

* trustedproxy.php sets 'proxies' again according to
  env('APP_TRUSTED_PROXIES') again
@welcome
Copy link

welcome bot commented Oct 21, 2020

Congrats on merging your first pull request! 🎉🎉🎉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants